Get rid of sassc

[byroot]

Context

Shipit never followup the various asset pipeline changes, and is still using sprockets 3.x with sassc, which is becoming a problem now, because Shipit is part of the ruby-bench suite and sassc is causing problem on ruby-head: ruby/ruby-bench#476 (ruby/ruby-bench@5893da2)

Solution

I looked at using the newer SASS stack (sass dart etc) but it's very tricky as it means upgrading sprockets and a lot of other things, some SASS functions need to be reimplemented, and the compiler is throwing lots of deprecations.

Overall, vanilla CSS is now much more powerful that it once was when Shipit started, and the Shipit CSS hasn't changed much in years, I believe we might as well use vanilla CSS, and that makes migrating to something other than sprockets 3.x much easier in the future.

Implementation

I did compile the CSS with the existing compiler and then cleaned it up and re-introduced data-uri helpers using ERB, etc.

We do lose some things such as a few color functions that are now hardcoded colors, but here again I think it's not a huge deal. If one day someone feel like doing an overall of the CSS they might as well start from scratch anyways.

We may also want to consider doing something similar for coffee-rails, but it's not a problem today.

cc @Edouard-chin @etiennebarrie @rafaelfranca

[Edouard-chin]

👍 The hardcoded color is fine if if the advantage is removing sassc.

@tdickers any concern on your side changing this ?