v0.44.3: Handle GithubOrganizationUnknown in GithubSyncJob#1466
Merged
v0.44.3: Handle GithubOrganizationUnknown in GithubSyncJob#1466
Conversation
When a webhook triggers a sync for a stack belonging to an unconfigured GitHub organization, GithubSyncJob raises an unhandled GithubOrganizationUnknown error. Log a warning and mark the stack as inaccessible, matching the pattern used for Octokit::NotFound.
tdickers
force-pushed
the
handle-github-org-unknown-in-sync-job
branch
from
0158037 to
ebc1a33
Compare
tdickers
changed the title
edilsonacjr
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder: this is a public repo.
When a webhook triggers a sync for a stack belonging to an unconfigured GitHub organization,
GithubSyncJobraises an unhandledGithubOrganizationUnknownerror. Log a warning and mark the stack as inaccessible, matching the pattern used forOctokit::NotFound.Marking as inaccessible shows a banner in the UI and skips deploy-related background jobs for the stack. The next successful sync automatically clears the flag.
This mirrors Shopify/shipit-engine#1454
Bumps version to 0.44.3.