Closed
Conversation
tobi
force-pushed
the
zjit-guardtype-frozen-elim
branch
from
1a03f53 to
7722f20
Compare
When GuardType operates on a value that is a known frozen object (from a constant), we can check at compile time if the object's type matches the guard. Since frozen objects cannot change their class, the runtime guard becomes unnecessary. This optimization eliminates redundant type guards when accessing methods on frozen constant objects, complementing the LoadField folding for ivar reads. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tobi
force-pushed
the
zjit-guardtype-frozen-elim
branch
from
7722f20 to
59f55f8
Compare
tekknolagi
reviewed
Dec 12, 2025
| self.make_equal_to(insn_id, val); | ||
| continue; | ||
| } | ||
| // If GuardType is on a frozen object, we can check at compile time if the |
There was a problem hiding this comment.
I think this should be implied by the is_a in the existing code; we can generally infer types from constant objects (VALUE pointers). Ideally we instead eliminate GuardShape instructions, which we don't have yet
There was a problem hiding this comment.
I think I misspoke when I said we needed to eliminate GuardType, sorry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code