vscode: Detect mise via shell PATH like other version managers#4109
Open
knu wants to merge 1 commit into
Open
Conversation
Previously mise was the only version manager whose detection and
executable resolution relied solely on a hardcoded list of installation
directories. Users who installed mise outside of `~/.local/bin`,
`/opt/homebrew/bin`, or `/usr/bin` had to set `miseExecutablePath`
explicitly, even when `mise` was already on their shell `PATH`.
Align mise with rbenv, rv, and asdf:
- Replace `detectMise()` with the standard `toolExists("mise")` probe,
which runs `mise --version` through the user's interactive shell so
any `PATH` is honored.
- Rewrite `Mise#findMiseUri` as `Mise#findMise` using `findExec`, so
installations under the well-known directories are still preferred
while unknown locations fall back to the shell `PATH`.
- Add `/usr/local/bin` and `/home/linuxbrew/.linuxbrew/bin` to the
candidate list to cover Homebrew Intel and Linuxbrew installations
that were previously missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously mise was the only version manager whose detection and executable resolution relied solely on a hardcoded list of installation directories. Users who installed mise outside of
~/.local/bin,/opt/homebrew/bin, or/usr/binhad to setmiseExecutablePathexplicitly, even whenmisewas already on their shellPATH.Implementation
Align mise with rbenv, rv, and asdf:
detectMise()with the standardtoolExists("mise")probe, which runsmise --versionthrough the user's interactive shell so anyPATHis honored.Mise#findMiseUriasMise#findMiseusingfindExec, so installations under the well-known directories are still preferred while unknown locations fall back to the shellPATH./usr/local/binand/home/linuxbrew/.linuxbrew/binto the candidate list to cover Homebrew Intel and Linuxbrew installations that were previously missed.Automated Tests
vscode/src/ruby/mise.ts