Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| const cartId = result?.cart?.id; | ||
| const headers = cartId ? cart.setCartId(result.cart.id) : new Headers(); | ||
| const {cart: cartResult, errors, warnings, userErrors} = result; | ||
| const {cart: cartResult, errors, warnings} = result; |
There was a problem hiding this comment.
userErrors stuff got deleted
There was a problem hiding this comment.
Yeah this was the one I discovered that prompted this whole thing!
| warnings={actionData?.warnings} | ||
| userErrors={actionData?.userErrors} | ||
| /> | ||
| <CartMain layout="page" cart={cart} /> |
There was a problem hiding this comment.
This was definitely unintentional
There was a problem hiding this comment.
Indeed, however these warnings and userErrors would only be rendered on the /cart route which is almost impossible to access as most cart is managed on the side cart (warnings and userErrors) would still not show in it.
| LENGTH: ['MM', 'CM', 'M', 'IN', 'FT', 'YD'], | ||
| AREA: ['M2', 'FT2'], | ||
| COUNT: ['ITEM'], | ||
| WEIGHT: ['MG', 'G', 'KG'], |
There was a problem hiding this comment.
These modifications ended up on main. Ie: the new units we had added got deleted and are still deleted. We need to add them back.
There was a problem hiding this comment.
Same thing with the tests too
| "@react-router/dev": "7.8.2", | ||
| "@react-router/fs-routes": "7.8.2", | ||
| "@shopify/cli": "~3.83.3", | ||
| "@shopify/cli": "~3.80.4", |
There was a problem hiding this comment.
Oops! This one was later updated though so not an issue now
|
This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days. |
3 participants
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist