Make --json output format same as it was before
#479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[serde(flatten)] | ||
| pub json_value: Option<serde_json::Value>, | ||
| /// The human readable representation of the bytes. | ||
| #[serde(skip)] |
Contributor
There was a problem hiding this comment.
I believe I introduced this for the codecs, but given that it's all json, maybe we should remove it while we are at it?
Contributor
Author
Contributor
There was a problem hiding this comment.
Right, but this is mostly to accommodate the raw codec, for which we couldn't make any assumptions when the cli flag was exposed
function-runner/src/container.rs
Line 37 in 218f79f
json, for all the other cases, humanized is pretty much a json representation if I'm not wrong? So we could drop humanized and simply stringify the json directly. OTOH, maybe it's fine to keep it, and instead we should remove the Raw option from the codec which is what really complicates things here. I'll leave it up to you in this case.
Contributor
There was a problem hiding this comment.
Yeah, we should probably remove the Raw codec. I'm fine doing that outside of this PR though.
saulecabrera
approved these changes
May 16, 2025
andrewhassan
approved these changes
May 16, 2025
| #[serde(flatten)] | ||
| pub json_value: Option<serde_json::Value>, | ||
| /// The human readable representation of the bytes. | ||
| #[serde(skip)] |
Contributor
There was a problem hiding this comment.
Yeah, we should probably remove the Raw codec. I'm fine doing that outside of this PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.