Update to include discount class filtering #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munarahmanatshop
force-pushed
the
04-30-update_to_include_discount_class_filtering
branch
from
dabbb0b to
6a2ed48
Compare
munarahmanatshop
force-pushed
the
04-30-update_to_include_discount_class_filtering
branch
from
9e49c9a to
d6c611a
Compare
jonathanhamel4
approved these changes
May 1, 2025
Contributor
jonathanhamel4
left a comment
jonathanhamel4
left a comment
There was a problem hiding this comment.
lgtm. Lets just make sure that we indeed want to remove the network templates.
devisscher
approved these changes
May 1, 2025
| @@ -1,7 +1,10 @@ | |||
| {%- if flavor contains "vanilla-js" -%} | |||
| // @ts-check | |||
Contributor
There was a problem hiding this comment.
We should probably remove this ts-check in the vanilla example?
munarahmanatshop
deleted the
04-30-update_to_include_discount_class_filtering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes from Shopify/discounts-reference-app#33 and deleted the JS+Rust network folder as we don't use it in CLI.
Only change made is to discount/default (for both JS + Rust).