Split Discount JS template test files #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devisscher
approved these changes
Apr 17, 2025
Contributor
devisscher
left a comment
devisscher
left a comment
There was a problem hiding this comment.
Nice! That was quick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split discount tests into separate files
This PR splits the combined discount test file into separate test files for each function:
generate_cart_run.test.liquidfor testing cart-based discountsgenerate_delivery_run.test.liquidfor testing delivery-based discountsdiscount.test.liquidfileThis change follows the one-test-file-per-implementation-file pattern, making it easier to maintain tests and implement new functionality. Tests continue to pass for both JavaScript and TypeScript flavors.