Skip to content

add new discount and network call templates #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devisscher merged 1 commit into from
Mar 14, 2025
Merged

add new discount and network call templates #599

devisscher merged 1 commit into from
Mar 14, 2025

Conversation

@jonathanhamel4
Copy link
Contributor

@jonathanhamel4 jonathanhamel4 commented Mar 13, 2025 •
edited
Loading

New CLI templates for network calls and multi-class discounts

Fixes https://github.com/Shopify/core-issues/issues/85521

@jonathanhamel4 jonathanhamel4 force-pushed the jh/updated-discount-templates branch 16 times, most recently from 436f865 to 7cad862 Compare March 13, 2025 20:22
@jonathanhamel4
Copy link
Contributor Author

jonathanhamel4 commented Mar 13, 2025

@AronZeng @dpwolf fyi this is the PR for the new templates

@jonathanhamel4 jonathanhamel4 force-pushed the jh/updated-discount-templates branch from 7cad862 to 0e77d0f Compare March 13, 2025 20:25
@jonathanhamel4 jonathanhamel4 marked this pull request as ready for review March 14, 2025 12:45
@jonathanhamel4 jonathanhamel4 force-pushed the jh/updated-discount-templates branch from 0e77d0f to 3f0f04b Compare March 14, 2025 12:48
devisscher
devisscher approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@devisscher devisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM for now, as we chatted yesterday, we might have some adjustments to make on the JS/TS example, but ok to merge so we can test CLI and scaffolding steps of the tutorials asap.

discounts/javascript/discount/default/vite.config.js
Copy link
Contributor

@devisscher devisscher Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this?

Copy link
Contributor Author

@jonathanhamel4 jonathanhamel4 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually added them because they are in other configs for discounts. Do we want to remove?

discounts/javascript/network/default/vite.config.js
Copy link
Contributor

@devisscher devisscher Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove perhaps?

@jonathanhamel4 jonathanhamel4 force-pushed the jh/updated-discount-templates branch 2 times, most recently from 206c583 to aba995f Compare March 14, 2025 13:32
@jonathanhamel4
Copy link
Contributor Author

jonathanhamel4 commented Mar 14, 2025

This LGTM for now, as we chatted yesterday, we might have some adjustments to make on the JS/TS example, but ok to merge so we can test CLI and scaffolding steps of the tutorials asap.

Note that since discounts/rust/discounts/default is removed, it will stop working as a template through the cli until the partner changes are done I think

@devisscher
Copy link
Contributor

devisscher commented Mar 14, 2025

This LGTM for now, as we chatted yesterday, we might have some adjustments to make on the JS/TS example, but ok to merge so we can test CLI and scaffolding steps of the tutorials asap.

Note that since discounts/rust/discounts/default is removed, it will stop working as a template through the cli until the partner changes are done I think

That should be ok, because we need the beta flag to be on to have that option in CLI.

@jonathanhamel4 jonathanhamel4 force-pushed the jh/updated-discount-templates branch from aba995f to 2ffe414 Compare March 14, 2025 17:37
@devisscher devisscher merged commit 056e0e7 into main Mar 14, 2025
4 checks passed
@devisscher devisscher deleted the jh/updated-discount-templates branch March 14, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devisscher devisscher devisscher approved these changes

@dpwolf dpwolf Awaiting requested review from dpwolf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanhamel4 @devisscher