Update discounts examples #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampetro
force-pushed
the
ap.update-discount-examples
branch
from
83d7071 to
b3e12d4
Compare
otheriault
approved these changes
May 22, 2025
| @@ -1,4 +1,4 @@ | |||
| api_version = "unstable" | |||
| api_version = "unst2025-04able" | |||
Contributor
There was a problem hiding this comment.
This should be 2025-04
Suggested change
| api_version = "unst2025-04able" | |
| api_version = "2025-04" |
Contributor
andrewhassan
left a comment
andrewhassan
left a comment
There was a problem hiding this comment.
LGTM aside from that one API version. Will approve once that's updated!
andrewhassan
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The discount templates in
function-exampleswere updated in Shopify/function-examples#618 and Shopify/function-examples#633Solution
Port those changes here, as this is the new home for Function templates using the Wasm API
Checklist