1308 include uid in templates #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Part of: https://github.com/Shopify/develop-app-outer-loop/issues/1308
New extension templates that have been added since the team moved partners extension templates in https://github.com/Shopify/extensions-templates/blob/main/templates.json and some are missing the uid property.
While the user can fix this in the context of running the deploy command by deploying a second time, in the context of dev it will not have a uid in the TOML, and will therefore not be properly recognized by the App Management API.
We therefore want to make sure each template adds the uid if available.
Solution
Ensure all templates add the uid if available.
All
shopify.extension.tomltemplate files based ontemplates.jsonBased on https://github.com/Shopify/extensions-templates/blob/main/templates.json, the full list of template files is:
Template files not adding
uidI added the
uidinsertion to the template files which didn't have it (3 files).Templates files which don't exist
I discovered three template files for the
order_submission_ruleextension which don't exist, because the extension was removed (see Shopify/function-examples#577) and so I deleted.Checklist