Skip to content

Conversation

@craigmichaelmartin
Copy link
Contributor

@craigmichaelmartin craigmichaelmartin commented Jan 3, 2025

Background

Part of: https://github.com/Shopify/develop-app-outer-loop/issues/1308

New extension templates that have been added since the team moved partners extension templates in https://github.com/Shopify/extensions-templates/blob/main/templates.json and some are missing the uid property.

While the user can fix this in the context of running the deploy command by deploying a second time, in the context of dev it will not have a uid in the TOML, and will therefore not be properly recognized by the App Management API.

We therefore want to make sure each template adds the uid if available.

Solution

Ensure all templates add the uid if available.

All shopify.extension.toml template files based on templates.json

Based on https://github.com/Shopify/extensions-templates/blob/main/templates.json, the full list of template files is:

Template files not adding uid

I added the uid insertion to the template files which didn't have it (3 files).

Templates files which don't exist

I discovered three template files for the order_submission_rule extension which don't exist, because the extension was removed (see Shopify/function-examples#577) and so I deleted.

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

Copy link

@pt2pham pt2pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Craig LGTM! As mentioned we'll want to figure out a better way to address app templates that have extension TOMLs as well and may want to more smartly generate these UIDs, but for now this ensures we can generate extensions correctly.

@craigmichaelmartin craigmichaelmartin merged commit 391a781 into main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants