Skip to content

[Security] Prevent absolute path bypass in sanitizeRelativePath#7550

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
sentinel-sanitize-path-fix-7639287056760175654
Draft

[Security] Prevent absolute path bypass in sanitizeRelativePath#7550
gonzaloriestra wants to merge 2 commits into
mainfrom
sentinel-sanitize-path-fix-7639287056760175654

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The sanitizeRelativePath function is intended to ensure a path provided by a user (e.g., in a configuration file) is relative and does not escape the intended directory. Previously, it only checked for .. segments but allowed absolute paths (starting with / or Windows drive letters like C:\) to pass through. This could allow an attacker to overwrite sensitive system files if the path is used as a destination in a file operation.

WHAT is this pull request doing?

  • Enhanced sanitizeRelativePath to detect and strip leading forward slashes and Windows drive letters.
  • Updated the function to filter out empty segments and drive letter segments.
  • Improved the warning message to correctly reflect that the path was insecure (either due to traversal or being absolute).
  • Added comprehensive unit tests in packages/cli-kit/src/public/node/path.test.ts to verify the fix across different OS path styles.

How to test your changes?

You can verify the behavior by calling the sanitizeRelativePath function with various inputs in a Node environment or via unit tests.

Duplicate check

  • Query: gh pr list --repo Shopify/cli --state all --limit 200 --search 'label:"Jules" "Security" in:title' --json number,title,state,url,body,files
  • Closest PR: [Security] Redact cookies in sanitized headers output (Different subsystem, unrelated to path sanitization).

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added unit tests.

PR created automatically by Jules for task 7639287056760175654 started by @gonzaloriestra

Enhance sanitizeRelativePath to strip leading slashes and Windows drive letters, ensuring paths are strictly relative. Add unit tests to verify cross-platform safety.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 15, 2026
Enhance sanitizeRelativePath to strip leading slashes and Windows drive letters, ensuring paths are strictly relative and cross-platform safe. Improve warning messages to accurately describe the security risk. Add unit tests for various traversal and absolute path scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant