Skip to content

Remove deprecated shopify app scaffold extension command#7525

Open
alfonso-noriega wants to merge 1 commit into05-remove-app-generate-schema-commandfrom
06-remove-app-scaffold-extension-command
Open

Remove deprecated shopify app scaffold extension command#7525
alfonso-noriega wants to merge 1 commit into05-remove-app-generate-schema-commandfrom
06-remove-app-scaffold-extension-command

Conversation

@alfonso-noriega
Copy link
Copy Markdown
Contributor

@alfonso-noriega alfonso-noriega commented May 11, 2026

WHY are these changes introduced?

The shopify app scaffold extension command was a hidden alias for shopify app generate extension deprecated long ago (it printed a "scaffold has been deprecated in favor of generate" warning when used). The command file was already unregistered from the CLI command map (pnpm shopify app:scaffold:extension returns Command not found), but the source file was left on disk as orphaned code. This PR removes the orphan.

Part of the deprecated-flag-removal stack: #7524 ← this PR → #7526.

WHAT is this pull request doing?

  • Deletes packages/app/src/cli/commands/app/scaffold/extension.ts (the AppScaffoldExtension class).
  • The empty packages/app/src/cli/commands/app/scaffold/ directory is also removed.
  • No registration changes are needed — the command was not registered in packages/app/src/cli/index.ts or packages/cli/oclif.manifest.json.
  • The analyticsNameOverride() returning 'app scaffold extension' in packages/app/src/cli/commands/app/generate/extension.ts is intentionally left in place to avoid breaking historical analytics dashboards.

How to test your changes?

  1. Run pnpm shopify app:scaffold:extension --help and confirm the Command not found error (same as before this change).
  2. Run pnpm shopify app generate extension --help and confirm the supported command still works.
  3. Confirm there is no packages/app/src/cli/commands/app/scaffold/ directory left in the repo.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

alfonso-noriega commented May 11, 2026

@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label May 11, 2026
@alfonso-noriega alfonso-noriega temporarily deployed to breaking-change-approval May 11, 2026 12:35 — with GitHub Actions Inactive
The `shopify app scaffold extension` command was a hidden alias for
`shopify app generate extension`, deprecated long ago. The file was
already unregistered from the CLI command map (`pnpm shopify app:scaffold:extension`
returns 'command not found'), so this change just deletes the orphaned source.
@alfonso-noriega alfonso-noriega force-pushed the 05-remove-app-generate-schema-command branch from da300cd to f23fe6c Compare May 11, 2026 12:52
@alfonso-noriega alfonso-noriega force-pushed the 06-remove-app-scaffold-extension-command branch from 559c629 to ec867ef Compare May 11, 2026 12:52
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.

💬 Head to #help-dev-platform to discuss timing and plan the release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
remove-app-deploy-force-flag.md '@shopify/app': major
remove-app-generate-extension-type-flag.md '@shopify/app': major
remove-app-generate-schema-command.md '@shopify/app': major
remove-app-release-force-flag.md '@shopify/app': major
remove-app-scaffold-extension-command.md '@shopify/app': major
remove-webhook-trigger-shared-secret-flag.md '@shopify/app': major
thin-webs-notice.md '@shopify/plugin-did-you-mean': major
thin-webs-notice.md '@shopify/plugin-cloudflare': major
thin-webs-notice.md '@shopify/create-app': major
thin-webs-notice.md '@shopify/cli-kit': major
thin-webs-notice.md '@shopify/store': major
thin-webs-notice.md '@shopify/theme': major
thin-webs-notice.md '@shopify/app': major
thin-webs-notice.md '@shopify/cli': major
thin-webs-notice.md '@shopify/e2e': major

@alfonso-noriega alfonso-noriega temporarily deployed to breaking-change-approval May 11, 2026 12:53 — with GitHub Actions Inactive
@alfonso-noriega alfonso-noriega marked this pull request as ready for review May 11, 2026 15:15
@alfonso-noriega alfonso-noriega requested review from a team as code owners May 11, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants