Skip to content

[Refactor] Fix incorrect Promise.all usage in app.ts#7512

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-promise-all-app-14262157258669614203
Draft

[Refactor] Fix incorrect Promise.all usage in app.ts#7512
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-promise-all-app-14262157258669614203

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The preDeployValidation function in packages/app/src/cli/models/app/app.ts was not correctly awaiting the validation of all extensions. It was using Promise.all([this.allExtensions.map(...)]), which creates an array containing a single element (the array of promises returned by .map()). Promise.all then resolves immediately because it sees an array of non-promise values (the array itself).

WHAT is this pull request doing?

Fixed the incorrect Promise.all usage by removing the unnecessary outer array brackets. Now it correctly awaits all validation promises: Promise.all(this.allExtensions.map(...)).

How to test your changes?

Run the tests for the app model:
pnpm --filter @shopify/app vitest run app.test.ts

Duplicate check

I ran git log --grep="Jules" --grep="Refactor" --pretty=format:"%h %s" --max-count=50 to check for previous similar PRs.

  • 088a35a45 [Refactor] Consolidate command execution in system.ts: Consolidates logic in a different subsystem.
  • aa120fbcf [Refactor] Optimize copyDirectoryContents with glob cwd: Focuses on path handling and performance in cli-kit.
  • b79412428 [Refactor] Remove redundant Knip ignoreDependencies entries: Addresses knip configuration hints.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct [bump type] (patch for bug fixes · minor for new features · major for [breaking changes]) and added a changeset with pnpm changeset add

PR Label: Jules


PR created automatically by Jules for task 14262157258669614203 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant