Skip to content

[Tests] Replace filesystem mocks with inTemporaryDirectory in write-app-logs.test.ts#7472

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
tester-improvement-fs-mock-removal-18165397204241329784
Draft

[Tests] Replace filesystem mocks with inTemporaryDirectory in write-app-logs.test.ts#7472
gonzaloriestra wants to merge 1 commit intomainfrom
tester-improvement-fs-mock-removal-18165397204241329784

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The write-app-logs.test.ts was using filesystem mocks (vi.mock('@shopify/cli-kit/node/fs')), which is discouraged in favor of using real temporary directories for better reliability and trust in the test suite.

WHAT is this pull request doing?

  • Refactored packages/app/src/cli/services/app-logs/dev/write-app-logs.test.ts to use inTemporaryDirectory.
  • Replaced mock assertions with real file content checks using readFile.
  • Cleaned up unused ignoreDependencies in the root package.json as suggested by pnpm knip.

How to test your changes?

Run the specific test file:
pnpm --filter @shopify/app vitest run src/cli/services/app-logs/dev/write-app-logs.test.ts

Verify that pnpm knip no longer reports unused item configuration hints.

Duplicate check

I attempted to run the gh command to check for duplicate PRs:
gh pr list --repo Shopify/cli --state all --limit 200 --search 'label:"Jules" "Tests" in:title' --json number,title,state,url,body,files
However, gh is not available in this environment. I checked the git logs and did not find any recent PRs with the [Tests] prefix that target this file or use this technique for this subsystem.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 18165397204241329784 started by @gonzaloriestra

…pp-logs.test.ts

- Refactored write-app-logs.test.ts to use real temporary directories.
- Replaced mock assertions with real file content checks.
- Cleaned up unused knip configuration in package.json.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant