Ask for an alias on login when the email is not found#6935
Ask for an alias on login when the email is not found#6935gonzaloriestra merged 2 commits intomainfrom
Conversation
|
/snapit |
This comment was marked as outdated.
This comment was marked as outdated.
Coverage report
Test suite run success3917 tests passing in 1503 suites. Report generated by 🧪jest coverage report action from 81f2cc6 |
c5fa758 to
72659f1
Compare
072b6e7 to
c81eb49
Compare
|
/snapit |
This comment was marked as outdated.
This comment was marked as outdated.
00f8bfe to
38eade8
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
38eade8 to
81f2cc6
Compare
|
/snapit |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/session/store.d.ts@@ -21,6 +21,13 @@ export declare function remove(): Promise<void>;
* @returns The alias for the session if it exists, otherwise undefined.
*/
export declare function getSessionAlias(userId: string): Promise<string | undefined>;
+/**
+ * Sets the alias for a given user's session and persists it.
+ *
+ * @param userId - The user ID of the session to update.
+ * @param alias - The new alias to set.
+ */
+export declare function setSessionAlias(userId: string, alias: string): Promise<void>;
/**
* Finds a session by its alias.
*
|
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260319121057Caution After installing, validate the version by running |
alfonso-noriega
left a comment
There was a problem hiding this comment.
Review assisted by pair-review
Merge activity
|
WHY are these changes introduced?
Apparently, sometimes the sessions are stored with the UUID (the fallback) instead of the email, or overwritten after some time (when refreshing).
See discussion in #6933
WHAT is this pull request doing?
shopify auth loginHow to test your changes?
shopify auth loginMeasuring impact
How do we know this change was effective? Please choose one:
Checklist