Skip to content

Amend downloadFiles loop to a Promise.all to ensure writes are complete #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvilGenius13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Amend downloadFiles loop to a Promise.all to ensure writes are complete #6863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/free-suns-stand.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/theme': patch
---

Change download files loop to a Promise all to ensure all files are always downloaded and display more accurate progress
7 changes: 2 additions & 5 deletions packages/theme/src/cli/utilities/theme-downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {batchedTasks, Task} from './batching.js'
import {MAX_GRAPHQL_THEME_FILES} from '../constants.js'
import {AdminSession} from '@shopify/cli-kit/node/session'
import {fetchThemeAssets} from '@shopify/cli-kit/node/themes/api'
import {ThemeFileSystem, Theme, Checksum, ThemeAsset} from '@shopify/cli-kit/node/themes/types'
import {ThemeFileSystem, Theme, Checksum} from '@shopify/cli-kit/node/themes/types'
import {renderTasks} from '@shopify/cli-kit/node/ui'
import {Writable} from 'stream'

Expand Down Expand Up @@ -90,8 +90,5 @@ async function downloadFiles(theme: Theme, fileSystem: ThemeFileSystem, filename
const assets = await fetchThemeAssets(theme.id, filenames, session)
if (!assets) return

// eslint-disable-next-line @typescript-eslint/no-misused-promises
assets.forEach(async (asset: ThemeAsset) => {
await fileSystem.write(asset)
})
await Promise.all(assets.map((asset) => fileSystem.write(asset)))
}
Loading