-
Notifications
You must be signed in to change notification settings - Fork 226
doctor-release command runs on development envs #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aswamy
wants to merge
1
commit into
main
Choose a base branch
from
02-18-doctor-release_command_runs_on_development_envs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−13
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
packages/cli/src/cli/services/doctor-release/context.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import {detectCliCommand} from './context.js' | ||
| import {describe, expect, test} from 'vitest' | ||
|
|
||
| describe('detectCliCommand', () => { | ||
| const handle = 'doctor-release:theme' | ||
|
|
||
| test('returns shopify when no handle is provided', () => { | ||
| expect(detectCliCommand(undefined, ['node', 'shopify', 'doctor-release', 'theme'])).toBe('shopify') | ||
| }) | ||
|
|
||
| test('detects npx shopify', () => { | ||
| const argv = ['npx', 'shopify', 'doctor-release', 'theme'] | ||
| expect(detectCliCommand(handle, argv)).toBe('npx shopify') | ||
| }) | ||
|
|
||
| test('detects direct shopify invocation', () => { | ||
| const argv = ['shopify', 'doctor-release', 'theme'] | ||
| expect(detectCliCommand(handle, argv)).toBe('shopify') | ||
| }) | ||
|
|
||
| test('detects pnpm shopify', () => { | ||
| const argv = ['pnpm', 'shopify', 'doctor-release', 'theme'] | ||
| expect(detectCliCommand(handle, argv)).toBe('pnpm shopify') | ||
| }) | ||
|
|
||
| test('detects node packages/cli/bin/dev.js', () => { | ||
| const argv = ['node', 'packages/cli/bin/dev.js', 'doctor-release', 'theme'] | ||
| expect(detectCliCommand(handle, argv)).toBe('node packages/cli/bin/dev.js') | ||
| }) | ||
|
|
||
| test('returns shopify when handle has no colon', () => { | ||
| const argv = ['node', 'shopify', 'doctor-release', 'theme'] | ||
| expect(detectCliCommand('doctor-release', argv)).toBe('node shopify') | ||
| }) | ||
|
|
||
| test('returns shopify when first topic is not found in argv', () => { | ||
| const argv = ['node', 'shopify', 'theme', 'init'] | ||
| expect(detectCliCommand(handle, argv)).toBe('shopify') | ||
| }) | ||
|
|
||
| test('returns shopify when first topic is the first argv element', () => { | ||
| const argv = ['doctor-release', 'theme'] | ||
| expect(detectCliCommand(handle, argv)).toBe('shopify') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvilGenius13 do you think this might be too fragile? I am not sure if we should just make a new arg passed in from the user.
If i were to steelman this approach, this would work in CI if we'd launch
theme-doctor themefrom a CI environment if it usednpx shopifyinstead ofshopifyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey so I console logged the input of running the command and I didn't get an argument setup of something like
npx,shopify, i gotSo I think we could just simplify the function to
return argv.slice(0, 2).join(' '), and then we only passdetectCliCommandthroughcreateDoctorContext. Let me know if I'm wrong!