Skip to content

Simplify tests to avoid o3 warnings#6861

Open
gonzaloriestra wants to merge 2 commits intomainfrom
simplify-tests
Open

Simplify tests to avoid o3 warnings#6861
gonzaloriestra wants to merge 2 commits intomainfrom
simplify-tests

Conversation

@gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

There's a new warning about code using o3 (openai), and we have some files that contain that string, causing false positives.

WHAT is this pull request doing?

Simplifies some test URLs to remove the o3 part and avoid the warning.

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/ui.d.ts
@@ -81,10 +81,7 @@ To see a list of supported npm commands, run:
  * │                                                          │
  * ╰──────────────────────────────────────────────────────────╯
  * [1] https://shopify.dev
- * [2] https://www.google.com/search?q=jh56t9l34kpo35tw8s28hn7s
- * 9s2xvzla01d8cn6j7yq&rlz=1C1GCEU_enUS832US832&oq=jh56t9l34kpo
- * 35tw8s28hn7s9s2xvzla01d8cn6j7yq&aqs=chrome.0.35i39l2j0l4j46j
- * 69i60.2711j0j7&sourceid=chrome&ie=UTF-8
+ * [2] https://www.google.com
  * [3] https://shopify.com
  *
  */

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.9% 14556/18449
🟡 Branches 73.23% 7223/9863
🟡 Functions 79.09% 3704/4683
🟡 Lines 79.25% 13763/17367

Test suite run success

3777 tests passing in 1455 suites.

Report generated by 🧪jest coverage report action from 7aab1c0

@gonzaloriestra gonzaloriestra marked this pull request as ready for review February 18, 2026 11:49
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner February 18, 2026 11:49
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copy link
Contributor

@isaacroldan isaacroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now using the substring "o3" is forbidden? 😅

Copy link
Contributor Author

Well, not forbidden, but annoying... Just asked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments