Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/ui.d.ts@@ -81,10 +81,7 @@ To see a list of supported npm commands, run:
* │ │
* ╰──────────────────────────────────────────────────────────╯
* [1] https://shopify.dev
- * [2] https://www.google.com/search?q=jh56t9l34kpo35tw8s28hn7s
- * 9s2xvzla01d8cn6j7yq&rlz=1C1GCEU_enUS832US832&oq=jh56t9l34kpo
- * 35tw8s28hn7s9s2xvzla01d8cn6j7yq&aqs=chrome.0.35i39l2j0l4j46j
- * 69i60.2711j0j7&sourceid=chrome&ie=UTF-8
+ * [2] https://www.google.com
* [3] https://shopify.com
*
*/
|
Coverage report
Test suite run success3777 tests passing in 1455 suites. Report generated by 🧪jest coverage report action from 7aab1c0 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
isaacroldan
left a comment
There was a problem hiding this comment.
So now using the substring "o3" is forbidden? 😅
|
Well, not forbidden, but annoying... Just asked here |
WHY are these changes introduced?
There's a new warning about code using
o3(openai), and we have some files that contain that string, causing false positives.WHAT is this pull request doing?
Simplifies some test URLs to remove the
o3part and avoid the warning.How to test your changes?
CI
Measuring impact
How do we know this change was effective? Please choose one:
Checklist