Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

Continuation of #6707

The release workflow is not working yet: https://github.com/Shopify/cli/actions/runs/20134579239/job/57784328999

/usr/bin/git commit -m Version Packages
[changeset-release/main e381fa697d] Version Packages
 21 files changed, 75 insertions(+), 42 deletions(-)
 delete mode 100644 .changeset/pretty-brooms-heal.md
/usr/bin/git push origin HEAD:changeset-release/main --force
remote: Permission to Shopify/cli.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/Shopify/cli/': The requested URL returned error: 403
Error: The process '/usr/bin/git' failed with exit code 128
    at m._setResult (/home/runner/work/_actions/changesets/action/e9cc34b540dd3ad1b030c57fd97269e8f6ad905a/dist/index.js:136:7258)
    at m.CheckComplete (/home/runner/work/_actions/changesets/action/e9cc34b540dd3ad1b030c57fd97269e8f6ad905a/dist/index.js:136:6686)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/changesets/action/e9cc34b540dd3ad1b030c57fd97269e8f6ad905a/dist/index.js:136:5723)
    at ChildProcess.emit (node:events:524:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)
Error: The process '/usr/bin/git' failed with exit code 128

WHAT is this pull request doing?

Apparently, when using OIDC authentication, NPM enforces provenance generation (which was previously optional/ignored with tokens), and provenance requires full git history to work correctly.

So I'm updating the Git checkout step to retrieve the full history with a fetch-depth of 0

How to test your changes?

Merge and check

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner December 11, 2025 16:01
@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.24% (+0.01% 🔼)
13925/17574
🟡 Branches
73.24% (+0.13% 🔼)
6806/9293
🟡 Functions
79.39% (+0.02% 🔼)
3567/4493
🟡 Lines
79.59% (+0% 🔼)
13154/16528
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🔴
... / execute.ts
0% 0% 0% 0%
🔴
... / status.ts
0% 0% 0% 0%
🔴
... / pull.ts
0% 100% 0% 0%
🟢
... / execute-operation.ts
92.86% 80% 100% 92.31%
🔴
... / pull.ts
0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
96.61% 92.11% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
92.98% 86.11% 100% 92.73%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
72.73% 62.5% 83.33% 71.88%
🟢
... / watch-bulk-operation.ts
100% 100% 100% 100%
🟢
... / common.ts
96.15% 93.33% 100% 95.45%
🟢
... / execute-command-helpers.ts
100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / execute.ts
0%
0% (-100% 🔻)
0% 0%
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
14.29% (+0.95% 🔼)
3.13% (+0.18% 🔼)
50% (-7.14% 🔻)
14.29% (+0.95% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3492 tests passing in 1408 suites.

Report generated by 🧪jest coverage report action from 488f5cc

Copy link
Contributor

@katiebauchman katiebauchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - correctly changes fetch-depth to retrieve full git history.
Quick question (maybe I don't understand fully): is fetching full history expected to resolve the 403 push error, or are there additional changes needed?

Copy link
Contributor Author

Which 403 push error? 🤔

I expect it to fix this error and hopefully the full release process: Error: The process '/usr/bin/git' failed with exit code 128

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@katiebauchman
Copy link
Contributor

Oh ok! I just saw in the original message the line that said fatal: unable to access 'https://github.com/Shopify/cli/': The requested URL returned error: 403 I might be reading that output wrong haha 🙃

@gonzaloriestra
Copy link
Contributor Author

Ahh, sorry, now I see it. Yeah, I guess it's the same error, let's see!

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 1303620 Dec 11, 2025
24 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-fetch-depth-release branch December 11, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants