-
Notifications
You must be signed in to change notification settings - Fork 224
Move command from shopify app execute to shopify app bulk execute
#6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move command from shopify app execute to shopify app bulk execute
#6679
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3448 tests passing in 1396 suites. Report generated by 🧪jest coverage report action from 942df86 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
6ae8599 to
d78d5ee
Compare
d78d5ee to
0416c8e
Compare
jordanverasamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 , code LGTM
0416c8e to
942df86
Compare

Resolves: https://github.com/orgs/shop/projects/208/views/34?pane=issue&itemId=140363174&issue=shop%7Cissues-api-foundations%7C1127
Inspired by: #6596 (comment)
Background
There was a design decision made that determined that Bulk operations have enough differences in behavior and requirements to merit a separate command (
shopify app bulk execute).Implementation
packages/app/src/cli/commands/app/execute.tsintopackages/app/src/cli/commands/app/bulk/execute.tsand changed the imports.packages/app/src/cli/index.tsfile.Tophatting
The new

shopify app bulk executecommand works!