Skip to content

Conversation

@ericlee878
Copy link
Contributor

@ericlee878 ericlee878 commented Dec 2, 2025

Resolves: https://github.com/orgs/shop/projects/208/views/34?pane=issue&itemId=140363174&issue=shop%7Cissues-api-foundations%7C1127

Inspired by: #6596 (comment)

Background

There was a design decision made that determined that Bulk operations have enough differences in behavior and requirements to merit a separate command (shopify app bulk execute).

Implementation

  • Moved packages/app/src/cli/commands/app/execute.ts into packages/app/src/cli/commands/app/bulk/execute.ts and changed the imports.
  • Changed the execute command index in the packages/app/src/cli/index.ts file.
  • Regenerated the manifest.

Tophatting

The new shopify app bulk execute command works!
Screenshot 2025-12-02 at 12.44.42 PM.png

Copy link
Contributor Author

ericlee878 commented Dec 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.17% (-0.06% 🔻)
13845/17488
🟡 Branches
73.13% (+0.02% 🔼)
6758/9241
🟡 Functions
79.33% (-0.04% 🔻)
3551/4476
🟡 Lines
79.53% (-0.05% 🔻)
13081/16447
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🔴
... / execute.ts
0% 0% 0% 0%
🔴
... / status.ts
0% 0% 0% 0%
🔴
... / pull.ts
0% 100% 0% 0%
🔴
... / pull.ts
0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
96% 90.63% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
91.23% 83.33% 100% 92.59%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
72.73% 62.5% 83.33% 71.88%
🟢
... / watch-bulk-operation.ts
100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
14.29% (+0.95% 🔼)
3.13% (+0.18% 🔼)
50% (-7.14% 🔻)
14.29% (+0.95% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3448 tests passing in 1396 suites.

Report generated by 🧪jest coverage report action from 942df86

@ericlee878 ericlee878 marked this pull request as ready for review December 2, 2025 20:45
@ericlee878 ericlee878 requested a review from a team as a code owner December 2, 2025 20:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@ericlee878 ericlee878 force-pushed the 12-02-move_command_from_shopify_app_execute_to_shopify_app_bulk_execute_ branch from 6ae8599 to d78d5ee Compare December 2, 2025 20:45
@ericlee878 ericlee878 requested a review from a team as a code owner December 2, 2025 20:45
@ericlee878 ericlee878 force-pushed the 12-02-move_command_from_shopify_app_execute_to_shopify_app_bulk_execute_ branch from d78d5ee to 0416c8e Compare December 2, 2025 20:48
Copy link
Contributor

@jordanverasamy jordanverasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 , code LGTM

@jordanverasamy jordanverasamy force-pushed the 12-02-move_command_from_shopify_app_execute_to_shopify_app_bulk_execute_ branch from 0416c8e to 942df86 Compare December 4, 2025 03:37
@jordanverasamy jordanverasamy added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit a59fc98 Dec 4, 2025
25 checks passed
@jordanverasamy jordanverasamy deleted the 12-02-move_command_from_shopify_app_execute_to_shopify_app_bulk_execute_ branch December 4, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants