3.87 Patch: Fix images not loading in theme app extensions #6618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graygilmore
force-pushed
the
gg-fix-tae-images-3.87-patch
branch
from
eee9f11 to
3d6eb87
Compare
Contributor
Coverage report
Test suite run success3356 tests passing in 1372 suites. Report generated by 🧪jest coverage report action from 718c173 |
Our wrapper around fs's `readFile` sets a default of `{encoding:
'utf8'}` to the options. This will cause any binary files (like images
or fonts) to not be read properly.
There isn't a way to disable the encoding based on how the function is
currently typed so I'm switching to fs's version of `readFile` which
will handle all file types correctly automatically.
graygilmore
force-pushed
the
gg-fix-tae-images-3.87-patch
branch
from
3d6eb87 to
718c173
Compare
graygilmore
changed the title
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.87.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.87.2";
\ No newline at end of file
|
EvilGenius13
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for v3.87 of #6614