Skip to content

[DNM] swap shopify_function dep from template to snapshot #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lopert wants to merge 3 commits into from
Closed

[DNM] swap shopify_function dep from template to snapshot #6603

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
162d3b8
swap shopify_function dep from template to local tarball
lopert Nov 11, 2025
f840ce4
use shopify_function snapshot directly
lopert Nov 11, 2025
b05fad4
workaround for tests
lopert Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/app/src/cli/services/generate/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
import {recursiveLiquidTemplateCopy} from '@shopify/cli-kit/node/liquid'
import {renderTasks} from '@shopify/cli-kit/node/ui'
import {downloadGitRepository} from '@shopify/cli-kit/node/git'
import {fileExists, inTemporaryDirectory, mkdir, moveFile, removeFile, glob} from '@shopify/cli-kit/node/fs'
import {fileExists, inTemporaryDirectory, mkdir, moveFile, removeFile, glob, writeFile} from '@shopify/cli-kit/node/fs'
import {joinPath, relativizePath} from '@shopify/cli-kit/node/path'
import {slugify} from '@shopify/cli-kit/common/string'
import {nonRandomUUID} from '@shopify/cli-kit/node/crypto'
Expand Down Expand Up @@ -183,6 +183,17 @@ async function functionExtensionInit({
taskList.push({
title: 'Installing additional dependencies',
task: async () => {
// Update the @shopify/shopify_function version in the template's package.json
const extensionPackageJsonPath = joinPath(directory, 'package.json')
if (await fileExists(extensionPackageJsonPath)) {
const packageJson = await readAndParsePackageJson(extensionPackageJsonPath)

if (packageJson.dependencies?.['@shopify/shopify_function']) {
packageJson.dependencies['@shopify/shopify_function'] = '0.0.0-snapshot-20251111164106'
await writeFile(extensionPackageJsonPath, JSON.stringify(packageJson, null, 2))
}
}

// We need to run install once to setup the workspace correctly
if (app.usesWorkspaces) {
await installNodeModules({packageManager: app.packageManager, directory: app.directory})
Expand Down