Avoid problems with theme extensions self built by external vite

[alfonso-noriega]

WHY are these changes introduced?

The current archiving functionality in zip and brotliCompress methods doesn't handle race conditions where files might be deleted during the archiving process. This can lead to errors and failed builds when files are removed while the archiving is in progress.

WHAT is this pull request doing?

Improves the archiving process to gracefully handle files that are deleted during the archiving operation:

1. Modifies the zip and brotliCompress functions to read file content immediately before adding to the archive
2. Adds error handling to skip files that are deleted during the archiving process
3. Adds comprehensive tests to verify the new behavior works correctly

How to test your changes?

theme-test.zip

1. Download the included zip with a test them app.
2. Run shopify app dev --path path/to./the/downloaded/app in a terminal
3. Within the app folder run pnpm theme-extension:dev to run vite
4. In a new terminal window, within the theme extension folder run the script rapid-changes.sh included in the zip.
   These steps will start a never ending loop of changes to the extension files in batches of a random size which will eventually trigger the error we are trying to reproduce.

Once the error is reproduced running dev with the latest CLI, to test the changes go to the CLI repo, checkout this branch, and run pnpm shopify app dev --path path/to./the/downloaded/app (don't forget to close the previously started dev session).

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[alfonso-noriega]

• Add resilliency to errors on concurrent build asset writes #6559
• Group events by extension to reduce triggered builds #6558
• Avoid problems with theme extensions self built by external vite #6553 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	79.27% (+0% 🔼)	13598/17154
🟡	Branches	73.15% (+0.01% 🔼)	6648/9088
🟡	Functions	79.35% (+0% 🔼)	3504/4416
🟡	Lines	79.63% (+0.01% 🔼)	12844/16129

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / archiver.ts	87.1% (-2.38% 🔻)	66.67%	76.47% (+1.47% 🔼)	91.23% (-1.08% 🔻)

Test suite run success

3358 tests passing in 1372 suites.

Report generated by 🧪jest coverage report action from d6c771d

[alfonso-noriega]

/snapit

[github-actions]

🫰✨ Thanks @alfonso-noriega! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251029171255

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[dmerand]

Had to make a slight change to the test script:

# Directory containing the files
DIR="${HOME}/Downloads/theme-test/extensions/theme-extension/frontend/entrypoints"

if [ ! -d "$DIR" ]; then
    echo "Directory $DIR does not exist. Exiting."
    exit 1
f

Tophat is giving me build errors that look the same on both branches though... Wondering if I'm missing steps?