Skip to content

Conversation

@jacobsteves
Copy link
Member

WHY are these changes introduced?

Bump function-runner to v7.0.0.

This new version returns a non-zero exit code whenever a function run fails (PR). While this was a major version for function-runner, I don't believe it constitutes a major version for the CLI.

How to test your changes?

  • rm -r packages/app/dist/cli/services/bin/ (clear out any cached downloaded binaries)
  • pnpm shopify app function build --path <path_to_function_extension> (downloads and runs Javy)
  • echo "{}" | pnpm shopify app function run --path <path_to_function_extension> (downloads and runs function-runner)
  • Make your function error (for JS, just throw an error for example)
  • Try running the function again, see a non-zero exit code

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes - none needed

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.33% (-0.01% 🔻)
8827/11717
🟡 Branches
70.63% (-0.02% 🔻)
4287/6070
🟡 Functions 75.2% 2313/3076
🟡 Lines 75.87% 8343/10996
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1994 tests passing in 900 suites.

Report generated by 🧪jest coverage report action from d5b69b8

@jacobsteves jacobsteves marked this pull request as ready for review December 18, 2024 20:33
@jacobsteves jacobsteves requested review from a team as code owners December 18, 2024 20:33
@jacobsteves jacobsteves added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit f20d127 Dec 19, 2024
@jacobsteves jacobsteves deleted the js.bump-function-runner-v7 branch December 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants