This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Added support to get AWS creds from IAM Roles#23
Open
rberger wants to merge 2 commits intoShopify:masterfrom
mistsys:rjb-iam-role
Open
Added support to get AWS creds from IAM Roles#23rberger wants to merge 2 commits intoShopify:masterfrom mistsys:rjb-iam-role
rberger wants to merge 2 commits intoShopify:masterfrom
mistsys:rjb-iam-role
Conversation
…credentials in databag. Made the volume recipe start with at least devid >= 'f'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed recipes to work if an IAM Role is being used instead of having credentials in databag in a way that should be backwards compatible.
Added an attribute
ebs[:creds][:iam_role]which when set true will not load or use the credentials databags and not set:aws_access_keyoraws_secret_access_keyin any of theaws_ebs_*resources.Made the volume recipe start with at least
devid >= 'f'. I found that if you didn't have the ephermal disks in use (at least with a t2 instance) it would start atdevid == 'b'which would then fail. Added logic to start atfor later.Updated the README to reflect the changes
Only tested for the volumes recipe though updated all the other recipes that use aws credentials