Return the HTTP response status and headers#108
Return the HTTP response status and headers#108joshuaflanagan wants to merge 2 commits into3.0.0from
Conversation
Callers should have access to the response headers - specifically the x-shipengine-request-id.
ShipEngineSDK/Api/AccountApi.cs
Outdated
| var (data, response) = await GetHttpResponse<GetAccountSettingsImagesResponseBody>(HttpMethods.Post, requestOptions.FullPath(), requestOptions.Data, methodClient, _config, cancellationToken); | ||
| var headers = response.Headers.ToDictionary(h => h.Key, h => h.Value.FirstOrDefault(), | ||
| StringComparer.InvariantCultureIgnoreCase); | ||
| return new ShipEngineResponse<GetAccountSettingsImagesResponseBody>(data, response.StatusCode, headers); |
There was a problem hiding this comment.
Am I reading this wrong or does this make the data inaccessible? From what I saw, the ShipEngineResponse holds the data in a private field.
There was a problem hiding this comment.
Oh, you're right. That field should be public. This was late-night sketching, I haven't run any of it yet - just stopped when I got it to compile.
ShipEngineSDK/Api/AccountApi.cs
Outdated
| var (data, response) = await GetHttpResponse<GetAccountSettingsImagesResponseBody>(HttpMethods.Post, requestOptions.FullPath(), requestOptions.Data, methodClient, _config, cancellationToken); | ||
| var headers = response.Headers.ToDictionary(h => h.Key, h => h.Value.FirstOrDefault(), | ||
| StringComparer.InvariantCultureIgnoreCase); | ||
| return new ShipEngineResponse<GetAccountSettingsImagesResponseBody>(data, response.StatusCode, headers); |
There was a problem hiding this comment.
Would all this be worth doing inside the client? I know this is autogenerated code so the repetition isn't a big deal, but it seems like core functionality that all consumers do.
There was a problem hiding this comment.
Yes, it would be better done in the client. Now that I am using a new method GetHttpResponse anyway, that should be possible. (originally tried to do it using the existing SendHttp...)
ShipEngineSDK/ShipEngineResponse.cs
Outdated
| @@ -0,0 +1,18 @@ | |||
| namespace ShipEngineSDK; | |||
There was a problem hiding this comment.
Just a formatting beef, but I think most of our code puts the namespace right above the class declaration and after the using statements (even though I know some tools don't like doing this)
3 participants
Callers should have access to the response headers - specifically the x-shipengine-request-id.
The significant changes are in
ShipEngineClient,ShipEngineResponseandapi.mustache. The rest are the result of regeneration.