Delete Location and NewLocation #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These should also be deleted from the cpg spec website. It looks like this is an upload of a |
ml86
approved these changes
May 22, 2025
Comment on lines
-94
to
-103
| symbol, | ||
| methodFullName, | ||
| methodShortName, | ||
| packageName, | ||
| lineNumber, | ||
| className, | ||
| classShortName, | ||
| nodeLabel, | ||
| filename, | ||
| columnNumber |
Contributor
There was a problem hiding this comment.
Please check which of these properties are only used in location and delete them as well.
johannescoetzee
force-pushed
the
flanders/delete-location-and-newlocation
branch
from
189a7a6 to
bf7e20a
Compare
johannescoetzee
force-pushed
the
flanders/delete-location-and-newlocation
branch
from
bf7e20a to
0e136d4
Compare
fixes PR build, since flatgraph writes to the test file on '.close' which leads to changes in the repo, which is not permitted for PR builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In joernio/joern#5482, we are switching to lazily computed location info. We are replacing the
LocationandNewLocationtypes with types defined in thejoernrepo, and the location info does not need to be in the cpg.