Skip to content

Add INSTALL_RUN_RUSH_LOCKFILE_PATH to pipeline runs#161

Merged
iclanton merged 1 commit intoSharePoint:mainfrom
iclanton:iclanton/add-install-run-rush-lockfile-path
Mar 23, 2026
Merged

Add INSTALL_RUN_RUSH_LOCKFILE_PATH to pipeline runs#161
iclanton merged 1 commit intoSharePoint:mainfrom
iclanton:iclanton/add-install-run-rush-lockfile-path

Conversation

@iclanton
Copy link
Copy Markdown
Contributor

Description

Sets INSTALL_RUN_RUSH_LOCKFILE_PATH on every install-run-rush.js invocation in CI, pinning the Rush version used to the one recorded in common/config/validation/rush-package-lock.json. This mirrors the change made in microsoft/rushstack#5710.

Changes:

  • Add common/config/azure-pipelines/templates/install-run-rush.yaml — a new wrapper template that sets the env var and accepts Arguments, DisplayName, Condition, and RepoPath parameters
  • Update templates/pack.yaml, templates/bump-versions.yaml, bump-versions.yaml, and publish.yaml to use the new template instead of inline script: steps
  • Add INSTALL_RUN_RUSH_LOCKFILE_PATH env var to the GitHub Actions CI job

How was this tested

Verified the pipeline YAML files are syntactically consistent with existing usage patterns.

Type of change

  • Bug fix
  • New feature
  • Template change (keep templates and examples in sync)
  • Docs/CI change (no source change)

Copilot AI review requested due to automatic review settings March 23, 2026 18:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR pins the Rush version used by CI by ensuring every install-run-rush.js invocation sets INSTALL_RUN_RUSH_LOCKFILE_PATH to the repo’s common/config/validation/rush-package-lock.json.

Changes:

  • Adds a new Azure Pipelines wrapper template to run install-run-rush.js with INSTALL_RUN_RUSH_LOCKFILE_PATH set.
  • Refactors existing Azure Pipeline templates/pipelines to use the new wrapper template rather than inline script: steps.
  • Sets INSTALL_RUN_RUSH_LOCKFILE_PATH at the GitHub Actions job level.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
common/config/azure-pipelines/templates/pack.yaml Switches Rush packaging step to the new wrapper template.
common/config/azure-pipelines/templates/install-run-rush.yaml Introduces wrapper template that sets INSTALL_RUN_RUSH_LOCKFILE_PATH for Rush invocations.
common/config/azure-pipelines/templates/bump-versions.yaml Switches version bump step to the new wrapper template.
common/config/azure-pipelines/publish.yaml Updates repo-toolbox install/build to use the wrapper template.
common/config/azure-pipelines/bump-versions.yaml Updates install and rebuild steps to use the wrapper template and set RepoPath.
.github/workflows/ci.yml Adds the env var to GitHub Actions CI jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread common/config/azure-pipelines/templates/install-run-rush.yaml
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@iclanton iclanton force-pushed the iclanton/add-install-run-rush-lockfile-path branch from 98efe49 to 89b9e65 Compare March 23, 2026 18:56
@iclanton iclanton enabled auto-merge (squash) March 23, 2026 19:00
@iclanton iclanton merged commit d81a2c6 into SharePoint:main Mar 23, 2026
3 checks passed
@nick-pape nick-pape requested a review from Copilot March 23, 2026 19:01
@iclanton iclanton deleted the iclanton/add-install-run-rush-lockfile-path branch March 23, 2026 19:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +2
# Template: Run install-run-rush.js with INSTALL_RUN_RUSH_LOCKFILE_PATH set.
# This pins the Rush version used in CI to the one recorded in rush-package-lock.json.
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says INSTALL_RUN_RUSH_LOCKFILE_PATH is set on every install-run-rush.js invocation in CI, but there are still CI templates invoking node common/scripts/install-run-rush.js ... directly (e.g. common/config/azure-pipelines/templates/record-versions.yaml for the Rushstack checkout). Either update those remaining steps to set the env var (potentially requiring this wrapper to accept a lockfile path) or adjust the PR description to match the actual scope.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants