Add INSTALL_RUN_RUSH_LOCKFILE_PATH to pipeline runs#161
Conversation
There was a problem hiding this comment.
Pull request overview
This PR pins the Rush version used by CI by ensuring every install-run-rush.js invocation sets INSTALL_RUN_RUSH_LOCKFILE_PATH to the repo’s common/config/validation/rush-package-lock.json.
Changes:
- Adds a new Azure Pipelines wrapper template to run
install-run-rush.jswithINSTALL_RUN_RUSH_LOCKFILE_PATHset. - Refactors existing Azure Pipeline templates/pipelines to use the new wrapper template rather than inline
script:steps. - Sets
INSTALL_RUN_RUSH_LOCKFILE_PATHat the GitHub Actions job level.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| common/config/azure-pipelines/templates/pack.yaml | Switches Rush packaging step to the new wrapper template. |
| common/config/azure-pipelines/templates/install-run-rush.yaml | Introduces wrapper template that sets INSTALL_RUN_RUSH_LOCKFILE_PATH for Rush invocations. |
| common/config/azure-pipelines/templates/bump-versions.yaml | Switches version bump step to the new wrapper template. |
| common/config/azure-pipelines/publish.yaml | Updates repo-toolbox install/build to use the wrapper template. |
| common/config/azure-pipelines/bump-versions.yaml | Updates install and rebuild steps to use the wrapper template and set RepoPath. |
| .github/workflows/ci.yml | Adds the env var to GitHub Actions CI jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
98efe49 to
89b9e65
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Template: Run install-run-rush.js with INSTALL_RUN_RUSH_LOCKFILE_PATH set. | ||
| # This pins the Rush version used in CI to the one recorded in rush-package-lock.json. |
There was a problem hiding this comment.
PR description says INSTALL_RUN_RUSH_LOCKFILE_PATH is set on every install-run-rush.js invocation in CI, but there are still CI templates invoking node common/scripts/install-run-rush.js ... directly (e.g. common/config/azure-pipelines/templates/record-versions.yaml for the Rushstack checkout). Either update those remaining steps to set the env var (potentially requiring this wrapper to accept a lockfile path) or adjust the PR description to match the actual scope.
Description
Sets
INSTALL_RUN_RUSH_LOCKFILE_PATHon everyinstall-run-rush.jsinvocation in CI, pinning the Rush version used to the one recorded incommon/config/validation/rush-package-lock.json. This mirrors the change made in microsoft/rushstack#5710.Changes:
common/config/azure-pipelines/templates/install-run-rush.yaml— a new wrapper template that sets the env var and acceptsArguments,DisplayName,Condition, andRepoPathparameterstemplates/pack.yaml,templates/bump-versions.yaml,bump-versions.yaml, andpublish.yamlto use the new template instead of inlinescript:stepsINSTALL_RUN_RUSH_LOCKFILE_PATHenv var to the GitHub Actions CI jobHow was this tested
Verified the pipeline YAML files are syntactically consistent with existing usage patterns.
Type of change