[SPH] Hutchison 2018 Multigrain#1616
Conversation
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Summary of ChangesHello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new multigrain dust model into the SPH solver, specifically focusing on the MonofluidTVI configuration. It introduces new particle fields and implements the numerical calculation for the time evolution of a key dust-related variable, S_j, following the methodology outlined in the Hutchison 2018 paper. Additionally, it enhances the solver's configuration safety by restricting experimental dust features. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces functionality for multigrain dust based on the Hutchison (2018) model. The changes span configuration and solver logic, adding new fields and a dedicated derivative update function. My review has identified a critical issue in the new derivative calculation where a key term is hardcoded to zero, which will lead to incorrect results. Additionally, there are several instances of unused variables and redundant code, likely from copy-pasting, which impact readability and performance. I've provided suggestions to clean this up and improve maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Workflow reportworkflow report corresponding to commit bafc5ea Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportSuggested changesDetailed changes :diff --git a/src/shammodels/sph/src/modules/ComputeEos.cpp b/src/shammodels/sph/src/modules/ComputeEos.cpp
index 81de5b52..3fcce237 100644
--- a/src/shammodels/sph/src/modules/ComputeEos.cpp
+++ b/src/shammodels/sph/src/modules/ComputeEos.cpp
@@ -87,7 +87,7 @@ struct RhoGetterMonofluid {
return accessed{h, epsilon, nvar_dust, pmass, hfact};
}
- void complete_event_state(sycl::event e) { buf_h.complete_event_state(e); }
+ void complete_event_state(sycl::event e) { buf_h.complete_event_state(std::move(e)); }
};
template<class Tscal>
@@ -126,7 +126,7 @@ struct RhoGetterSJ {
return accessed{h, s_j, nvar_dust, pmass, hfact};
}
- void complete_event_state(sycl::event e) {
+ void complete_event_state(const sycl::event& e) {
buf_h.complete_event_state(e);
buf_s_j.complete_event_state(e);
}
diff --git a/src/shammodels/sph/src/pySPHModel.cpp b/src/shammodels/sph/src/pySPHModel.cpp
index baad3c82..bc6f769e 100644
--- a/src/shammodels/sph/src/pySPHModel.cpp
+++ b/src/shammodels/sph/src/pySPHModel.cpp
@@ -277,7 +277,7 @@ void add_instance(py::module &m, std::string name_config, std::string name_model
.def(
"set_dust_stopping_times",
[](TConfig &self, std::vector<Tscal> ts) {
- self.dust_config.stopping_times = ts;
+ self.dust_config.stopping_times = std::move(ts);
})
.def("add_ext_force_point_mass", &TConfig::add_ext_force_point_mass)
.def( |
1 participant
No description provided.