Introduces quadratic scaling for more precise control with small stick movement.

[fewtarius]

This PR changes analog input scaling to scale quadratically instead of linearly which makes small movement less abrupt for more precise control.

[pastaq]

Can you explain a bit more why this is necessary? As a global change I'm concerned that it might be too opinionated.

[fewtarius]

Can you explain a bit more why this is necessary? As a global change I'm concerned that it might be too opinionated.

It's better for precise aiming as it changes the scaling algorithm to be more human response like, micro adjustment with small stick movements while keeping high sensitivity for large stick movements. It's not technically necessary, I'm happy to just keep it in my fork if you don't think it fits.

[ShadowApex]

I think this would be a good option to have, but we should make this configurable (and off by default for now).

We could add this as a capability config option:

capability_map.rs

#[derive(Debug, Deserialize, Serialize, Clone, JsonSchema, PartialEq)]
#[serde(rename_all = "snake_case")]
pub struct AxisCapability {
    pub name: String,
    pub direction: Option<String>,
    pub deadzone: Option<f64>,
    pub quadratic_scaling: Option<bool>,
}

Then we can check for the option in the translate function:

value.rs

// Axis -> Axis
Gamepad::Axis(_) => {
    let use_scaling = target_config
        .gamepad
        .as_ref()
        .and_then(|gamepad| gamepad.axis.as_ref())
        .and_then(|axis| axis.quadratic_scaling)
        .unwrap_or(false);

    match use_scaling {
        false => Ok(self.clone()),
        true => match self {
            InputValue::Vector2 { x, y } => {
                let scaled_x = x.map(|v| v * v.abs());
                let scaled_y = y.map(|v| v * v.abs());
                Ok(InputValue::Vector2 {
                    x: scaled_x,
                    y: scaled_y,
                })
            }
            _ => Ok(self.clone()),
        },
    }
}

[pastaq]

Add as optional setting per @ShadowApex comment

[fewtarius]

I think this would be a good option to have, but we should make this configurable (and off by default for now).

We could add this as a capability config option:

capability_map.rs

#[derive(Debug, Deserialize, Serialize, Clone, JsonSchema, PartialEq)]
#[serde(rename_all = "snake_case")]
pub struct AxisCapability {
    pub name: String,
    pub direction: Option<String>,
    pub deadzone: Option<f64>,
    pub quadratic_scaling: Option<bool>,
}

Then we can check for the option in the translate function:

value.rs

// Axis -> Axis
Gamepad::Axis(_) => {
    let use_scaling = target_config
        .gamepad
        .as_ref()
        .and_then(|gamepad| gamepad.axis.as_ref())
        .and_then(|axis| axis.quadratic_scaling)
        .unwrap_or(false);

    match use_scaling {
        false => Ok(self.clone()),
        true => match self {
            InputValue::Vector2 { x, y } => {
                let scaled_x = x.map(|v| v * v.abs());
                let scaled_y = y.map(|v| v * v.abs());
                Ok(InputValue::Vector2 {
                    x: scaled_x,
                    y: scaled_y,
                })
            }
            _ => Ok(self.clone()),
        },
    }
}

Alright, I'll submit the changes when I can.

[fewtarius]

@ShadowApex @pastaq let me know if you need any other changes. Sorry for the delay.