Add Bridge & Chain span tools; fix rotated-part dimension persistence#22
Merged
Conversation
Bridge & Chain (two-click build tools, in the demo stack's bridge style) - New JOINTS-section tools: click a part (or empty space) then a second point to span a chain of hinged segments. "Bridge" lays stiff planks that sag under load; "Chain" drapes a rope of small light links. - Segments are normal parts and links are exact-pivot "pin" hinges (a new internal joint kind, no marker), so a span renders, saves, loads and deletes like anything else. The existing rigid "Rope" joint is unchanged. - Tightened the palette button metrics so the two extra tools fit. Rotated-part dimension persistence (fixes a latent bug) - Dynamic boxes render as rotated polygons, so a rotated box's the width/height becomes its inflated bounding box; partLine saved that, so rotated parts (the Angle control, and angled span segments) reloaded at the wrong size. Each part now records its design size in uW/uH at creation, and save/resize/labels use those. Axis-aligned parts are unaffected (uW/uH == the width/height), so existing saves stay identical. setPartDimension resizes in an upright frame so rotated parts scale right. https://claude.ai/code/session_01AyoQTVuyLtPMrR5oVW6FFr
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5c8fac037
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+2303
to
+2304
| if tHit is empty and gJointTool is not "hinge" and gJointTool is not "bridge" and gJointTool is not "chain" then | ||
| put "Part B must be a part for a " & gJointTool & " joint (Hinge, Bridge and Chain can pin to the world)." into gStatus |
There was a problem hiding this comment.
Bridge and Chain only permit an empty-space world anchor on the second click. The first-click branch at lines 2286-2292 still rejects an empty hit and uses gPendCtrl is empty to mean that no endpoint is pending, so users cannot perform the documented “empty space, then second point” flow or anchor the start of a span to the world. Add separate pending-state tracking and support a world-backed first endpoint.
Useful? React with 👍 / 👎.
Additions (mirrored in the standalone Kit and the demo's embedded copy, unit-consistent with the existing px/deg wrappers): - b2kImpulse ctrl, ix, iy one-shot mass-aware kick (b2ApplyImpulse) - b2kTorque ctrl, torque continuous turning force (b2ApplyTorque) - b2kSleep ctrl send a body to sleep (pairs with b2kWake) - b2kSetSleepThreshold ctrl, pxPerSec - b2kSpinRate(ctrl) angular-velocity getter, deg/s (pairs with b2kSpin) - b2kIsBullet(ctrl) / b2kIsEnabled(ctrl) state getters - b2kRopeSetLength joint, px set a distance joint's exact rest length Robustness: - b2kSetBounce / b2kSetFriction / b2kSetDensity now no-op when the control has no shape yet, instead of passing an empty handle to the core (avoids errors when called on a bodiless or not-yet-shaped control). Documented in docs/kit-reference.md. All additive; no existing behaviour changed. https://claude.ai/code/session_01AyoQTVuyLtPMrR5oVW6FFr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge & Chain (two-click build tools, in the demo stack's bridge style)
Rotated-part dimension persistence (fixes a latent bug)
https://claude.ai/code/session_01AyoQTVuyLtPMrR5oVW6FFr