Prevent invalid used ID's#2357
Conversation
ravichandra1998g
left a comment
There was a problem hiding this comment.
Hello @SumithThota
Thank you for your submission. It appears that this pull request contains more files than described in the title. (it contains 4 files).
Please review and update the pull request to either remove the extra/unintended files or to update the description to be more comprehensive. Ensure your contributions are meaningful and adhere to the project’s standards. [If applicable: You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future.]. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.
|
Hi @ravichandra1998g Actully there exists 2 readme files in each locations 1 and 2 that is the reason they are conflicting each other and got ignored 1 file while pushing. Do I need to raise an Issue for this and maintain the correct README.md file at these locations, please do respond |
|
@ravichandra1998g I just raised a new issue #2367 regarding this problem could you check it out and assign that issue to me |
|
Just update your PR description to make it clear that those readme changes are intended to be part of this pr and it'll be good to go. |
|
@wiz0floyd yeah the #2381 has just merged if this PR #2357 merges does it conflicts each other regarding the issue of readme files or should i need to create new PR for the current changes? |
PR Description:
Prevent Invalid User ID
This ServiceNow Business Rule prevents inserting or updating a record when:
user_nameis missing or invalid.first_nameandlast_nameare missing or invalid.Functionality Breakdown
1.
isInvalid(value)trueif:null,undefined, or empty ("")"null"Example:
2.
current.setAbortAction(true)3.
gs.addErrorMessage("...")Notes
gs.addErrorMessage()helps users understand the validation reason.Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions