Fix: simplify incident cancellation UI action with native confirmation dialog#2346
Closed
Sriharsha19 wants to merge 5 commits intoServiceNowDevProgram:mainfrom
Closed
Conversation
Contributor
|
Hello @Sriharsha19 We appreciate the effort you’ve put into this contribution. We’ve labeled it as hacktoberfest-accepted so it still counts toward your Hacktoberfest progress. Thank you for contributing! |
ravichandra1998g
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Reference:
This pull request addresses the issue I raised in #2299 by implementing the proposed fixes and enhancements.
PR Description:
This PR refactors the incident cancellation UI Action by replacing the existing GlideModal confirmation with a simpler, native JavaScript confirm() dialog. The change improves code readability, reduces complexity, and enhances maintainability while retaining the full functional behavior.
Changes Made:
Benefits:
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions
Visual Proof
Cancel Incidentbutton on the incident form:Cancel Incidenta pop up is displayed asking for user confirmation-When user clicks on

okthen the incident is cancelled and work notes is also added for traceability.Button Visibility :