Fix out-of-order return in ATF step snippet#1752
Merged
wiz0floyd merged 1 commit intoServiceNowDevProgram:mainfrom Oct 3, 2025
Merged
Conversation
This would cause the output message of the step to not be set correctly in the success case
Contributor
ravichandra1998g
left a comment
There was a problem hiding this comment.
Thank you for your submission. However, it appears that this pull request is incomplete. It lacks A README.md file that describes the code snippet. Please complete your contribution by adding the necessary elements and resubmit or update this pull request for further review. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.
Contributor
Author
|
Hey @ravichandra1998g there's a readme for this snippet already here - is the intent that I create another one? Even for minor fixes like this? |
16 tasks
Contributor
|
Looks good. We've cleared up the readme concerns with the reviewer team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This would cause the output message of the step to not be set correctly in the success case
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions