Fix loading exp_dir using row_index in xray and add error handling.#283
Merged
amanjaiswal73892 merged 2 commits intomainfrom Aug 27, 2025
Merged
Fix loading exp_dir using row_index in xray and add error handling.#283amanjaiswal73892 merged 2 commits intomainfrom
amanjaiswal73892 merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this squirrel.
_.-"""-,
.' ..::. `\
/ .::' `'` /
/ .::' .--.=;
| ::' / C ..\
| :: | \ _.)
\ ':| / \
'-, \./ \)\)
`-| );/
'--'-'Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/analyze/agent_xray.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Emilianopp
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use _row_index column for getting exp_dir from agent_df instead of iloc. This fixes errors when multiple agents are loaded in result_df.
This pull request improves the robustness of the
update_exp_resultmethod inagent_xray.pyby adding error handling and warnings for cases where the providedrow_indexis missing or duplicated in the DataFrame.Error handling and data validation:
_row_index, raising aValueErrorand settingself.exp_resulttoNone._row_index, using the first match.Description by Korbit AI
What change is being made?
Enhance the loading of
exp_dirby utilizingrow_indexin xray and introduce error handling for cases of missing or duplicate indices.Why are these changes being made?
The changes address an issue where the incorrect or multiple rows could be accessed due to
row_indexmismatches, potentially causing errors or undefined behavior. Error handling is added to improve robustness by raising an error when no matchingrow_indexis found and issuing a warning if multiple rows are found, selecting the first entry by default.