Merged
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this shark.
(`.
\ `.
) `._..---._
\`. __...---` o )
\ `._,--' , ___,'
) ,-._ \ ) _,-'
/,' ``--.._____\/--''Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/analyze/agent_xray.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
* tutorial * Update readme to include test note * update toml to dynamic requirements and add uv.lock file * Add tutorial to setup python env with uv * tutorial 2 * Update dependencies in pyproject.toml and uv.lock to allow for newer versions of torch and add anthropic * Implement code changes to enhance functionality and improve performance * Fix tutorial instructions by moving git clone and cd commands to the correct section * Refactor tutorial content and remove commented-out dependencies in pyproject.toml * add instruction to activate the env * Add support for GPT-5 models and update tutorial instructions * Update OpenAI API Key instructions in tutorial * Refactor tutorial headings for consistency and clarity * add oai oss and gpt-5 models * Update deperecated param `max_tokens`-> `max_completion_tokens` in chat_api * add OpenRouter versions of gpt 5 model series. * port o3 model to openrouter * update response api test * remove deprecated o1-mini model from main.py * Add Gpt-5-nano in tool-use-agent * fix GPT 5 mini and nano config * Add litellm pricing as a backup princing backend. * Add GPT-5 mini agent * Add GPT-5-Mini to agentlab-assistant. * Add initial readme for prompt injection tutorial * add ipykernal and dot_env to dependency * add notebook to setup miniwob and launch experiments. * update formatting in launch_experiments.ipynb * update readme in 2_eval_on_miniwob * update readme for 2_eval_on_miniwob and grammar fix. * grammar fix readme tutorial 2. * Add prompt injection tutorials and update attack scenarios - Created new attack scenario in `attack_2.txt` to simulate identity verification prompts for agents and digital assistants. - Added detailed instructions and observations in `prompt_0.txt` for listing reviewers mentioning small ear cups. - Introduced `prompt_2.txt` to track food-related shopping expenses for March 2023, including comprehensive action space and interaction history. * update T1 readme with a note to install additional playwright deps. * Update readme.md * Update readme.md * Update readme.md * clear output * add miniwob automatic install in agentlab. * update experiment.py to include miniwob auto-install and envars export in T2 * black refactor agent-config.py * Add cmd to checkout tutorial branch * remove launch_experiment notebook from T2 * minor fixes in T1 read me and spell check, * update CI/CD to use uv * Implement code changes to enhance functionality and improve performance * Update README and experiment script for clarity and consistency * Fix stale tests. * fix stale test * add darglint as dev dependency * update CI/CD apply formatting only src. * update darglint to be run from py3.12 --------- Co-authored-by: recursix <alex.lacoste.shmu@gmail.com>
amanjaiswal73892
force-pushed
the
fix-xray-seeds
branch
from
637ef0f to
f2e7b40
Compare
amanjaiswal73892
approved these changes
Aug 20, 2025
Collaborator
amanjaiswal73892
left a comment
amanjaiswal73892
left a comment
There was a problem hiding this comment.
Great Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Fix the xray analysis bug by using a unique row index for disambiguating DataFrame selections and enhancing type checks with BGymStepInfo compatibility.
Why are these changes being made?
The changes resolve issues with selecting the correct experiment directories by relying on a unique row index rather than task_name and seed, which previously led to ambiguities. This update stabilizes the data processing pipeline and ensures accurate results in experiment selection and profiling. Additionally, the type check adjustment supports compatibility with BGymStepInfo, enhancing framework flexibility.