Refonte de la Pipeline CI/CD #278

PiquelChips · 2025-04-21T13:22:59Z

Petit résumé de la PR:

Système de versionnage et de CI/CD pour le plugin

Étape nécessaire afin que la PR soit fini (si PR en draft)

Les Issues corrigée(s) en commun : [FEAT] Versionnage pour le Plugin #265

Decrivez vos changements

Modification du schéma de PR (plus simple)
Ajout de la configuration de le génération automatique de description de release (release.yml)
Regroupement des workflow de build et de test + simplification et nettoyage de ceux-ci (build-test.yml)
Ajout d'un workflow qui vérifie que chaque PR à une milestone
Ajout d'un workflow qui à la fermeture d'un milestone:
- Vérifie que le milestone à un nom conforme (il ne peux que contenir des lettres, des chiffres, des ".", des "-" et des "_")
- Build le plugin
- Créer une release GitHub
- Upload le plugin sur le serveur
Ajout d'un workflow qui envoie un message discord à la publication d'une release (cf exemple de message ci-dessous)
Refonte du build.gradle:
- Simplification de la syntax d'import et de certain paramètres de build (par @iambibi)
- Ajout des variables TAG et SNAPSHOT afin de mieux gérer le versioning des builds du plugin (en local, en test ou en prod)
Ajout d'un message de bienvenue avec un lien qui redirige vers le milestone de la dernière MAJ

Un exemple du message discord. Bien sûr, les vrais auront des vrais changements et un nom de milestone plus joli:

Le système de versioning:

En local sans rien
Avec SNAPSHOT=true
Avec SNAPSHOT=true et GITHUB_SHA=azertyuiopoiuytrezertyuiooiuytre (simulation de l'envrionment de build de build-test.yml)
Avec TAG=2.1.3 (simulation de l'environment de release)

Merci a @iambibi d'avoir commencé, j'ai repris son code ici pour mon système

from https://github.com/ServerOpenMC/PluginV2VersioningTest

Fix

Update README.md

mqlkfds

Plus de tests

* remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo

… closure

iambibi · 2025-04-21T15:44:51Z

On est d'accord qu'on reste sur le même type pour la version ?
OpenMC-2.0.0-beta-1 ? Et si possible mettre OpenMC-{version}-SNAPSHOT si plugin build en local

iambibi · 2025-04-26T10:53:53Z

ahh non on s'est mal compris, je pouvais faire une commande qui restart avec un delai mais je n'ai aucun moyen de l'éxecuté lors d'une release. Une solution serait de modifié l'action d'upload du plugin pour qu'elle execute une commande sur le serveur. stv je peux voire avec le mainteneur de repo

allez tente écoute

PiquelChips · 2025-04-26T10:57:35Z

rexlManu/pterodactyl-upload-action#5

voila l'issue que j'ai créé.
au pire, si il ne répond pas avant la fin de la semaine, je ferais la modif sur un fork et on utiliseras le fork a la place

iambibi · 2025-04-26T11:27:57Z

rexlManu/pterodactyl-upload-action#5

voila l'issue que j'ai créé. au pire, si il ne répond pas avant la fin de la semaine, je ferais la modif sur un fork et on utiliseras le fork a la place

ouais dommage ça sera pas tellement automatiser mais bon pg on verra ce qu'il dit

ri1ongithub · 2025-04-26T12:02:04Z

le repo a plus vrm l'air d'être maintenu, il répondra prob pas avant 2 ans.

PiquelChips · 2025-04-26T12:10:25Z

ouais donc j'ai fais le changement et j'ai modifié l'action pour utiliser mon fork

PiquelChips · 2025-04-26T12:11:27Z

je peux pas le tester car j'ai pas de serveur pterodactyl a disposition mais tu peux regarder les changements que j'ai fait normalement tt va bien

PiquelChips · 2025-04-26T12:12:01Z

normalement c'est bon ducoup mais faudra tester

iambibi · 2025-04-26T12:12:57Z

ok

PiquelChips · 2025-04-26T12:39:31Z

bon bah il a merge la PR presque immédiatement donc je vais remettre son action

PiquelChips · 2025-04-26T12:40:49Z

je viens de voir que ri1 a fork mon repo
tu veux que je mette ton fork à la place?

PiquelChips · 2025-04-26T12:41:09Z

je te conseil de forker l'original et pas le mien car je vais pas le maintenir

iambibi · 2025-04-26T14:36:59Z

pas compris mais dite moi quand c'est good pour que je continue à review et ptet a mettre en test

PiquelChips · 2025-04-26T16:57:29Z

Ducoup j'ai mis l'action fork par ServerOpenMC.
Si toute les variables nécessaires ont été mises dans les paramètres du repo alors tout est bon et tu peux review

iambibi · 2025-04-26T16:59:17Z

Ducoup j'ai mis l'action fork par ServerOpenMC. Si toute les variables nécessaires ont été mises dans les paramètres du repo alors tout est bon et tu peux review

je vais faire une petite pause, je reprends surement ce soir vers 21h 22h je metterais en place le versionning

iambibi · 2025-04-26T16:59:48Z

tu as bien enlevé la notif discord? (on va eviter de ping 10 fois les joueurs)

PiquelChips · 2025-04-26T17:05:09Z

non j'ai juste enlevé le @NotifOpenMC

PiquelChips · 2025-04-26T17:05:37Z

Ducoup j'ai mis l'action fork par ServerOpenMC. Si toute les variables nécessaires ont été mises dans les paramètres du repo alors tout est bon et tu peux review

je vais faire une petite pause, je reprends surement ce soir vers 21h 22h je metterais en place le versionning

ok

ri1ongithub

lgtm

.github/workflows/build-test.yml

iambibi · 2025-04-26T18:39:21Z

Bon on va tester tout ça @PiquelChips

* fix: List.of() creates immutable list * fix: Rename invitation variable to avoid confusion * feat: _iambibi's work from https://github.com/ServerOpenMC/PluginV2VersioningTest * Update README.md * feat: fix creation of tag * Update README.md * Update README.md * remove adding tags on merge * feat: add merging of milestone branch into master on milestone close * feat: combined all build and test workflows * fix: clean up workflows and translate * feat: merge PR into milestone branch * Plus de tests * Update README.md (#5) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * Feat (#7) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * Feat (#8) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * Feat (#9) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: check-milestone had suplicated code * remove test * feat: simplified pipeline * fix typos (I hope) * feat: add automatic release notes generation * translated release.yml * remove unnecessary step in PR template * fix: version numbre not being set properly in plugin.yml * feat: removed unneccessary workflows * feat: release posted on discord * fix checkout version for discord notif * change actions version * fix: change @ in discord notification * simplify workflows * Feat (#14) * fix: List.of() creates immutable list * fix: Rename invitation variable to avoid confusion * feat: _iambibi's work from https://github.com/ServerOpenMC/PluginV2VersioningTest * Update README.md * feat: fix creation of tag * Update README.md * Update README.md * remove adding tags on merge * feat: add merging of milestone branch into master on milestone close * feat: combined all build and test workflows * fix: clean up workflows and translate * feat: merge PR into milestone branch * Plus de tests * Update README.md (#5) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * Feat (#7) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * Feat (#8) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * Feat (#9) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: check-milestone had suplicated code * remove test * feat: simplified pipeline * fix typos (I hope) * feat: add automatic release notes generation * translated release.yml * remove unnecessary step in PR template * fix: version numbre not being set properly in plugin.yml * feat: removed unneccessary workflows * feat: release posted on discord * fix checkout version for discord notif * change actions version * fix: change @ in discord notification * simplify workflows --------- Co-authored-by: GitHub Actions <actions@github.com> * add configuration of git in milestone-close * Feat (#15) * fix: List.of() creates immutable list * fix: Rename invitation variable to avoid confusion * feat: _iambibi's work from https://github.com/ServerOpenMC/PluginV2VersioningTest * Update README.md * feat: fix creation of tag * Update README.md * Update README.md * remove adding tags on merge * feat: add merging of milestone branch into master on milestone close * feat: combined all build and test workflows * fix: clean up workflows and translate * feat: merge PR into milestone branch * Plus de tests * Update README.md (#5) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * Feat (#7) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * Feat (#8) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * Feat (#9) * remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo * clean check-milestone * feat: milestone-create workflow * feat: add deleting branch when milestone-closed * clean up milestone workflows * fix: wrong branch name * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: naming of jar in release workflow * feat: clean pr template * feat: workflows.md to explain the pipeline * fix: check-milestone had suplicated code * remove test * feat: simplified pipeline * fix typos (I hope) * feat: add automatic release notes generation * translated release.yml * remove unnecessary step in PR template * fix: version numbre not being set properly in plugin.yml * feat: removed unneccessary workflows * feat: release posted on discord * fix checkout version for discord notif * change actions version * fix: change @ in discord notification * simplify workflows * add configuration of git in milestone-close --------- Co-authored-by: GitHub Actions <actions@github.com> * fix: tag name in milestone-close * improve milestone-close release-create * fix: wrong filepath for release * undo last thing * removed old stuff from milestone-close * feat: simplify tag system * feat: add tagless binary to release * feat: add deploy to server to milestone-close * fix branding of discord release * feat: join message with milestone url * fix: error expanding version and milestone url in build.gradle * fix: token used for milestone-close release * feat: name format verification * feaet: remove . from file name * fix name check * fix name check * fix regex pattern * fix: build.gradle naming scheme * fix tag system * fix indentation * fix: welcome message * feat: /omcrestart * fix: dont restart pterodactyl server * feat: make restart work in console properly * feat: modifie regex for more patters + explain error * feat: only console can send the message * translate discord release * fix translattion * feat: add sending console command on release * fix regex * fix regex * use ServerOpenMC action for pterodactyl upload --------- Co-authored-by: GitHub Actions <actions@github.com>

PiquelChips added 9 commits April 20, 2025 09:21

fix: List.of() creates immutable list

5b67c64

fix: Rename invitation variable to avoid confusion

1c9ff25

feat: _iambibi's work

aa00342

from https://github.com/ServerOpenMC/PluginV2VersioningTest

Update README.md

d11123b

Merge pull request #1 from PiquelChips/Fix

f697aaf

Fix

feat: fix creation of tag

0a79695

Update README.md

f1d8c36

Update README.md

50c18e5

Merge pull request #2 from PiquelChips/Fix

5590eb2

Update README.md

PiquelChips changed the title ~~Le Versining~~ Refonte de la Pipeline CI/CD Apr 21, 2025

PiquelChips and others added 17 commits April 21, 2025 16:19

remove adding tags on merge

cc16f2f

feat: add merging of milestone branch into master on milestone close

8ccbae5

feat: combined all build and test workflows

aa5ea48

fix: clean up workflows and translate

ecc0195

feat: merge PR into milestone branch

a7abbaa

Merge pull request #3 from PiquelChips/feat

07c5977

mqlkfds

Plus de tests

44c55a9

Merge pull request #4 from PiquelChips/PiquelChips-patch-1

2699f08

Plus de tests

Merge PR #4 into milestone-Yippeeeee

6e57a3f

Update README.md (#5)

cdfa758

Merge PR #5 into milestone-Yippeeeee

5fdeaf5

remove pr-close workflow

7143566

feat: check if target branch is correct

1d8d0bc

fix typo

e7659c2

fix typo

d474e0c

Feat (#7)

0260180

* remove pr-close workflow * feat: check if target branch is correct * fix typo * fix typo

Merge milestone branch milestone-Yippeeeee into master upon milestone…

c5a43ac

… closure

iambibi added the 📦 Feature Ajout d'une fonctionnalité label Apr 21, 2025

iambibi linked an issue Apr 21, 2025 that may be closed by this pull request

[FEAT] Versionnage pour le Plugin #265

Closed

PiquelChips added 2 commits April 26, 2025 14:09

fix translattion

5beab1b

feat: add sending console command on release

c0b863a

PiquelChips added 2 commits April 26, 2025 14:17

fix regex

75e816a

fix regex

354c51f

use ServerOpenMC action for pterodactyl upload

e9993f9

ri1ongithub approved these changes Apr 26, 2025

View reviewed changes

ri1ongithub reviewed Apr 26, 2025

View reviewed changes

.github/workflows/build-test.yml Show resolved Hide resolved

Merge branch 'ServerOpenMC:master' into feat

981d20d

iambibi approved these changes Apr 26, 2025

View reviewed changes

iambibi merged commit c546c81 into ServerOpenMC:master Apr 26, 2025
2 of 3 checks passed

PiquelChips deleted the feat branch April 26, 2025 18:48

Refonte de la Pipeline CI/CD #278

Refonte de la Pipeline CI/CD #278

Uh oh!

Conversation

PiquelChips commented Apr 21, 2025 • edited by iambibi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Petit résumé de la PR:

Étape nécessaire afin que la PR soit fini (si PR en draft)

Decrivez vos changements

Uh oh!

iambibi commented Apr 21, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

ri1ongithub commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

PiquelChips commented Apr 26, 2025

Uh oh!

ri1ongithub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iambibi commented Apr 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PiquelChips commented Apr 21, 2025 •

edited by iambibi

Loading