Add new System.Diagnostics.UnreachableException polyfill#89
Open
0xced wants to merge 1 commit intoSergio0694:mainfrom
Open
Add new System.Diagnostics.UnreachableException polyfill#890xced wants to merge 1 commit intoSergio0694:mainfrom
System.Diagnostics.UnreachableException polyfill#890xced wants to merge 1 commit intoSergio0694:mainfrom
Conversation
cremor
reviewed
May 14, 2024
src/PolySharp.SourceGenerators/EmbeddedResources/System.Diagnostics.UnreachableException.cs
Outdated
Show resolved
Hide resolved
cremor
reviewed
May 14, 2024
src/PolySharp.SourceGenerators/EmbeddedResources/System.Diagnostics.UnreachableException.cs
Outdated
Show resolved
Hide resolved
0xced
force-pushed
the
UnreachableException
branch
2 times, most recently
from
805df3a to
a2c4dd2
Compare
|
Is this ever going to be provided? We are still running our own implementation of UnreachableException, but would prefer to receive it through PolySharp. |
Contributor
Author
|
I just rebased on develop with a few improvements.
|
Contributor
Author
|
Is there anything holding this pull request @Sergio0694? It looks like several people are interested in it. |
Contributor
Author
|
I see there's some recent activity here in #127. Please don't forget about this pull request too if you're goint to release a new version of PolySharp. 😉 |
0xced
force-pushed
the
UnreachableException
branch
from
a2c4dd2 to
5471e00
Compare
The System.Diagnostics.UnreachableException.cs file was not actually auto-generated (see Sergio0694#88). Fixes Sergio0694#60
0xced
force-pushed
the
UnreachableException
branch
from
5471e00 to
adde2b4
Compare
Contributor
Author
|
But it still makes sense when targeting .NET Standard. Any chance to get this merged, @Sergio0694? |
Contributor
|
Ping @Sergio0694 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Additional context
The
System.Diagnostics.UnreachableException.csfile was not actually auto-generated (see #88).Also, only the English localization was considered for the exception message.