Fix XSS via Unsanitized innerHTML in Search Highlights#39
Conversation
- Escape HTML special characters in search result text before injection - Escape HTML and regex special characters in search query to ensure safe and correct matching - Add comprehensive unit tests for highlightMatch logic including security edge cases
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
yashrastogi
changed the title
1 participant
What: This PR fixes a Cross-Site Scripting (XSS) vulnerability in the
SearchBarComponenthighlighting logic.Risk: Previously, the
highlightMatchfunction directly injected unsanitized text into[innerHTML], allowing malicious actors to execute scripts if they could control the content of search results (e.g., via GitHub issues or Slack messages indexed by the system). It was also vulnerable to Regex injection which could lead to application errors or potentially ReDoS.Solution: The
highlightMatchfunction now:&,<,>,",') in the input text.<mark>tags around the matching terms.Comprehensive unit tests have been added in
src/app/components/search-bar/search-bar.spec.tsto verify the fix and prevent regressions.