Skip to content

align trace and indexing file data format #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcholic merged 2 commits into from
Jan 2, 2026
Merged

align trace and indexing file data format #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19d92e
align trace and indexing file data format
rcholic Jan 2, 2026
06ca7f7
fix windows tests
rcholic Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 201 additions & 14 deletions sentience/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"""

import asyncio
import hashlib
import re
import time
from typing import TYPE_CHECKING, Any, Optional
Expand Down Expand Up @@ -95,6 +96,24 @@ def __init__(
# Step counter for tracing
self._step_count = 0

def _compute_hash(self, text: str) -> str:
"""Compute SHA256 hash of text."""
return hashlib.sha256(text.encode("utf-8")).hexdigest()

def _get_element_bbox(self, element_id: int | None, snap: Snapshot) -> dict[str, float] | None:
"""Get bounding box for an element from snapshot."""
if element_id is None:
return None
for el in snap.elements:
if el.id == element_id:
return {
"x": el.bbox.x,
"y": el.bbox.y,
"width": el.bbox.width,
"height": el.bbox.height,
}
return None

def act( # noqa: C901
self,
goal: str,
Expand Down Expand Up @@ -343,15 +362,99 @@ def act( # noqa: C901

# Emit step completion trace event if tracer is enabled
if self.tracer:
self.tracer.emit(
"step_end",
{
"success": result.success,
"duration_ms": duration_ms,
"action": result.action,
# Get pre_url from step_start (stored in tracer or use current)
pre_url = snap.url
post_url = self.browser.page.url if self.browser.page else None

# Compute snapshot digest (simplified - use URL + timestamp)
snapshot_digest = f"sha256:{self._compute_hash(f'{pre_url}{snap.timestamp}')}"

# Build LLM data
llm_response_text = llm_response.content
llm_response_hash = f"sha256:{self._compute_hash(llm_response_text)}"
llm_data = {
"response_text": llm_response_text,
"response_hash": llm_response_hash,
"usage": {
"prompt_tokens": llm_response.prompt_tokens or 0,
"completion_tokens": llm_response.completion_tokens or 0,
"total_tokens": llm_response.total_tokens or 0,
},
step_id=step_id,
}

# Build exec data
exec_data = {
"success": result.success,
"action": result.action,
"outcome": result.outcome
or (
f"Action {result.action} executed successfully"
if result.success
else f"Action {result.action} failed"
),
"duration_ms": duration_ms,
}

# Add optional exec fields
if result.element_id is not None:
exec_data["element_id"] = result.element_id
# Add bounding box if element found
bbox = self._get_element_bbox(result.element_id, snap)
if bbox:
exec_data["bounding_box"] = bbox
if result.text is not None:
exec_data["text"] = result.text
if result.key is not None:
exec_data["key"] = result.key
if result.error is not None:
exec_data["error"] = result.error

# Build verify data (simplified - based on success and url_changed)
verify_passed = result.success and (
result.url_changed or result.action != "click"
)
verify_signals = {
"url_changed": result.url_changed or False,
}
if result.error:
verify_signals["error"] = result.error

# Add elements_found array if element was targeted
if result.element_id is not None:
bbox = self._get_element_bbox(result.element_id, snap)
if bbox:
verify_signals["elements_found"] = [
{
"label": f"Element {result.element_id}",
"bounding_box": bbox,
}
]

verify_data = {
"passed": verify_passed,
"signals": verify_signals,
}

# Build complete step_end event
step_end_data = {
"v": 1,
"step_id": step_id,
"step_index": self._step_count,
"goal": goal,
"attempt": attempt,
"pre": {
"url": pre_url,
"snapshot_digest": snapshot_digest,
},
"llm": llm_data,
"exec": exec_data,
"post": {
"url": post_url,
},
"verify": verify_data,
}

self.tracer.emit("step_end", step_end_data, step_id=step_id)

return result

Expand Down Expand Up @@ -1026,15 +1129,99 @@ async def act( # noqa: C901

# Emit step completion trace event if tracer is enabled
if self.tracer:
self.tracer.emit(
"step_end",
{
"success": result.success,
"duration_ms": duration_ms,
"action": result.action,
# Get pre_url from step_start (stored in tracer or use current)
pre_url = snap.url
post_url = self.browser.page.url if self.browser.page else None

# Compute snapshot digest (simplified - use URL + timestamp)
snapshot_digest = f"sha256:{self._compute_hash(f'{pre_url}{snap.timestamp}')}"

# Build LLM data
llm_response_text = llm_response.content
llm_response_hash = f"sha256:{self._compute_hash(llm_response_text)}"
llm_data = {
"response_text": llm_response_text,
"response_hash": llm_response_hash,
"usage": {
"prompt_tokens": llm_response.prompt_tokens or 0,
"completion_tokens": llm_response.completion_tokens or 0,
"total_tokens": llm_response.total_tokens or 0,
},
step_id=step_id,
}

# Build exec data
exec_data = {
"success": result.success,
"action": result.action,
"outcome": result.outcome
or (
f"Action {result.action} executed successfully"
if result.success
else f"Action {result.action} failed"
),
"duration_ms": duration_ms,
}

# Add optional exec fields
if result.element_id is not None:
exec_data["element_id"] = result.element_id
# Add bounding box if element found
bbox = self._get_element_bbox(result.element_id, snap)
if bbox:
exec_data["bounding_box"] = bbox
if result.text is not None:
exec_data["text"] = result.text
if result.key is not None:
exec_data["key"] = result.key
if result.error is not None:
exec_data["error"] = result.error

# Build verify data (simplified - based on success and url_changed)
verify_passed = result.success and (
result.url_changed or result.action != "click"
)
verify_signals = {
"url_changed": result.url_changed or False,
}
if result.error:
verify_signals["error"] = result.error

# Add elements_found array if element was targeted
if result.element_id is not None:
bbox = self._get_element_bbox(result.element_id, snap)
if bbox:
verify_signals["elements_found"] = [
{
"label": f"Element {result.element_id}",
"bounding_box": bbox,
}
]

verify_data = {
"passed": verify_passed,
"signals": verify_signals,
}

# Build complete step_end event
step_end_data = {
"v": 1,
"step_id": step_id,
"step_index": self._step_count,
"goal": goal,
"attempt": attempt,
"pre": {
"url": pre_url,
"snapshot_digest": snapshot_digest,
},
"llm": llm_data,
"exec": exec_data,
"post": {
"url": post_url,
},
"verify": verify_data,
}

self.tracer.emit("step_end", step_end_data, step_id=step_id)

return result

Expand Down
6 changes: 3 additions & 3 deletions sentience/extension/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@ async function handleScreenshotCapture(_tabId, options = {}) {
async function handleSnapshotProcessing(rawData, options = {}) {
const MAX_ELEMENTS = 10000; // Safety limit to prevent hangs
const startTime = performance.now();

try {
// Safety check: limit element count to prevent hangs
if (!Array.isArray(rawData)) {
throw new Error('rawData must be an array');
}

if (rawData.length > MAX_ELEMENTS) {
console.warn(`[Sentience Background] ⚠️ Large dataset: ${rawData.length} elements. Limiting to ${MAX_ELEMENTS} to prevent hangs.`);
rawData = rawData.slice(0, MAX_ELEMENTS);
Expand Down Expand Up @@ -186,7 +186,7 @@ async function handleSnapshotProcessing(rawData, options = {}) {
// Add timeout protection (18 seconds - less than content.js timeout)
analyzedElements = await Promise.race([
wasmPromise,
new Promise((_, reject) =>
new Promise((_, reject) =>
setTimeout(() => reject(new Error('WASM processing timeout (>18s)')), 18000)
)
]);
Expand Down
2 changes: 1 addition & 1 deletion sentience/extension/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function handleSnapshotRequest(data) {
if (responded) return; // Already responded via timeout
responded = true;
clearTimeout(timeoutId);

const duration = performance.now() - startTime;

// Handle Chrome extension errors (e.g., background script crashed)
Expand Down
Loading