upload screenshots along with traces #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot Upload Analysis
Date: 2026-01-01
Question: Does the SDK upload screenshots and traces separately? Does it convert base64 to image bytes?
Current Implementation Analysis
1. Screenshot Inclusion in Trace Events
Location:
sdk-python/sentience/agent.py(lines 821-830 for async, 181-190 for sync)Current Behavior:
{ "url": snap.url, "element_count": len(snap.elements), "timestamp": snap.timestamp, "elements": elements_data, # screenshot is NOT included! }snap.screenshotfield exists in the Snapshot object but is not emitted to the tracer