Skip to content

Commit 6ffadab

Browse files
committed
fix tests2
1 parent faede27 commit 6ffadab

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

tests/test_cloud_tracing.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,11 @@ def test_cloud_trace_sink_index_file_missing(self, capsys):
690690
# Mock successful trace upload
691691
mock_put.return_value = Mock(status_code=200)
692692

693+
# Mock /v1/traces/complete response (this will still be called)
694+
complete_response = Mock()
695+
complete_response.status_code = 200
696+
mock_post.return_value = complete_response
697+
693698
# Create sink
694699
sink = CloudTraceSink(upload_url, run_id=run_id, api_key="sk_test_123")
695700
sink.emit({"v": 1, "type": "run_start", "seq": 1})
@@ -700,8 +705,11 @@ def test_cloud_trace_sink_index_file_missing(self, capsys):
700705
# Verify trace upload succeeded
701706
assert mock_put.called
702707

703-
# Verify index upload was not attempted (index file missing)
704-
assert not mock_post.called
708+
# POST is called once for /v1/traces/complete, but NOT for /v1/traces/index_upload
709+
# (because index file is missing)
710+
assert mock_post.call_count == 1
711+
# Verify it was the complete call, not index_upload
712+
assert "/v1/traces/complete" in mock_post.call_args[0][0]
705713

706714
# Verify warning was printed
707715
captured = capsys.readouterr()

0 commit comments

Comments
 (0)