Skip to content

Commit faede27

Browse files
committed
fix tests
1 parent 143144b commit faede27

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

tests/test_cloud_tracing.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -557,12 +557,17 @@ def test_cloud_trace_sink_index_upload_success(self):
557557
"upload_url": "https://sentience.nyc3.digitaloceanspaces.com/traces/test.index.json.gz"
558558
}
559559

560+
# Mock successful /v1/traces/complete response
561+
complete_response = Mock()
562+
complete_response.status_code = 200
563+
560564
# Mock successful index upload
561565
index_upload_response = Mock()
562566
index_upload_response.status_code = 200
563567

564568
mock_put.side_effect = [trace_response, index_upload_response]
565-
mock_post.return_value = index_url_response
569+
# POST is called twice: once for index_upload, once for complete
570+
mock_post.side_effect = [index_url_response, complete_response]
566571

567572
# Create sink and emit events
568573
sink = CloudTraceSink(upload_url, run_id=run_id, api_key="sk_test_123")
@@ -577,10 +582,14 @@ def test_cloud_trace_sink_index_upload_success(self):
577582
# Verify trace upload
578583
assert mock_put.call_count == 2 # Once for trace, once for index
579584

580-
# Verify index upload URL request
585+
# Verify index upload URL request (first POST call)
581586
assert mock_post.called
582-
assert "/v1/traces/index_upload" in mock_post.call_args[0][0]
583-
assert mock_post.call_args[1]["json"] == {"run_id": run_id}
587+
assert mock_post.call_count == 2 # index_upload + complete
588+
589+
# Check first POST call (index_upload)
590+
first_post_call = mock_post.call_args_list[0]
591+
assert "/v1/traces/index_upload" in first_post_call[0][0]
592+
assert first_post_call[1]["json"] == {"run_id": run_id}
584593

585594
# Verify index file upload
586595
index_call = mock_put.call_args_list[1]
@@ -674,7 +683,7 @@ def test_cloud_trace_sink_index_file_missing(self, capsys):
674683

675684
with patch("sentience.cloud_tracing.requests.put") as mock_put, \
676685
patch("sentience.cloud_tracing.requests.post") as mock_post, \
677-
patch("sentience.cloud_tracing.write_trace_index") as mock_write_index:
686+
patch("sentience.trace_indexing.write_trace_index") as mock_write_index:
678687
# Mock index generation to fail (simulating missing index)
679688
mock_write_index.side_effect = Exception("Index generation failed")
680689

0 commit comments

Comments
 (0)