Fix Server sketch compilation: add forward declaration for purgePendingConfigNotes#266
Open
Fix Server sketch compilation: add forward declaration for purgePendingConfigNotes#266
purgePendingConfigNotes#266Conversation
…Notes Co-authored-by: dorkmo <1923070+dorkmo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Arduino compilation error in TankAlarm-112025 server sketch
Fix Server sketch compilation: add forward declaration for Feb 28, 2026
purgePendingConfigNotes
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Arduino compilation failure in the Server sketch by adding a missing forward declaration so handleConfigCancelPost() can call purgePendingConfigNotes() before its definition.
Changes:
- Added
static uint8_t purgePendingConfigNotes(const char *clientUid);to the existing forward-declarations block in the Server sketch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleConfigCancelPostcallspurgePendingConfigNotesat line ~6850, but the function is defined at line ~7295 with no prior forward declaration, causing the Arduino preprocessor to fail with "not declared in this scope".Change
Added one forward declaration to the existing declarations block alongside
dispatchPendingConfigs:Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.