Add Python tab references to BiDi W3C log docs#2643
Open
ajithrao2509 wants to merge 4 commits into
Open
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
Contributor
Review Summary by QodoAdd Python tab references to W3C BiDi log docs
WalkthroughsDescription• Adds Python tab references to W3C BiDi Log documentation • References existing Python test examples for console logs • References existing Python test examples for JS exceptions • Adds placeholder for missing JS logs Python example • Removes unnecessary blank lines for consistency Diagramflowchart LR
A["W3C BiDi Log Documentation"] -->|"Add Python tabs"| B["Console logs section"]
A -->|"Add Python tabs"| C["JS exceptions section"]
A -->|"Add placeholder"| D["JS logs section"]
B -->|"Reference"| E["test_bidi_logging.py L7-L15"]
C -->|"Reference"| F["test_bidi_logging.py L31-L39"]
D -->|"Placeholder"| G["badge-code"]
File Changes1. website_and_docs/content/documentation/webdriver/bidi/w3c/log.en.md
|
Contributor
Member
|
@ajithrao2509 , thanks for the PR, please add for all languages, besides the english file. |
Author
Hi @rpallavisharma, done! Added Python tabs to all translated files. zh-cn, pt-br, and ja. Let me know if anything else is needed. |
Member
|
thanks @ajithrao2509 . tlc members please review @SeleniumHQ/selenium-tlc . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2642
What this PR does
Adds Python tab references to the W3C BiDi Log documentation page.
Four files changed:
website_and_docs/content/documentation/webdriver/bidi/w3c/log.en.mdwebsite_and_docs/content/documentation/webdriver/bidi/w3c/log.zh-cn.mdwebsite_and_docs/content/documentation/webdriver/bidi/w3c/log.pt-br.mdwebsite_and_docs/content/documentation/webdriver/bidi/w3c/log.ja.mdMotivation and Context
The W3C BiDi Log page had no Python tab in any section. Python examples
already exist in
examples/python/tests/bidi/test_bidi_logging.py—this PR simply references them in the correct documentation page.
Types of changes
Checklist