You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
fixed frame code error in java, csharp and python
Motivation and Context
fixed frame code error in java, csharp and python
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
-iframe1=driver.find_element(By.NAME, "iframe1-name") # (This line doesn't switch, just locates)+iframe1 = driver.find_element(By.NAME, "iframe1-name") # (This line doesn't switch, just locates)
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: The suggestion correctly points out a violation of the PEP 8 style guide. Adding a space around the assignment operator in iframe1= improves code readability and consistency. This is a valid but minor style improvement.
the frame code for java, csharp and python example had an issue which was fixed in this. all checks have passed so merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
fixed frame code error in java, csharp and python
Motivation and Context
fixed frame code error in java, csharp and python
Types of changes
Checklist
PR Type
bug_fix
Description
Fixed incorrect frame switching code in Java, C#, and Python examples
Updated variable usage to correctly reference located iframe elements
Ensured frame switch uses the correct WebElement in all languages
Changes walkthrough 📝
FramesTest.java
Corrected frame switching logic in Java frame testexamples/java/src/test/java/dev/selenium/interactions/FramesTest.java
iframe1)iframe1)FramesTest.cs
Fixed frame switching error in C# frame testexamples/dotnet/SeleniumDocs/Interactions/FramesTest.cs
iframe1)iframe1)test_frames.py
Fixed frame switching bug in Python frame testexamples/python/tests/interactions/test_frames.py
iframe1)iframe1)