You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Fixed Frame Code- Demo -Purpose
Motivation and Context
Fixed Frame Code- Demo -Purpose
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
There appears to be a duplicate Python tab in the Japanese documentation. The same Python code snippet is included twice in the tabpane, which could confuse readers.
The Python example for switching to iframe has inconsistent indentation which could cause confusion. The code should follow a consistent indentation pattern.
{{< tab header="Python" >}}
# switching to second iframe based on index
iframe = driver.find_elements(By.TAG_NAME,'iframe')[1]# switch to selected iframe
driver.switch_to.frame(iframe)
There's a duplicate Python tab in the tabpane. The second Python tab at lines 49-50 is redundant as there's already a Python tab showing lines 45-46 above. This creates confusion for users reading the documentation.
-{{< tab header="Python" text=true >}}-{{< gh-codeblock path="examples/python/tests/interactions/test_frames.py#L49-L50" >}}-{{< /tab >}}+<!-- Remove this duplicate tab as it's already included above -->
Apply this suggestion
Suggestion importance[1-10]: 8
__
Why: The suggestion correctly identifies a duplicate Python tab in the documentation that shows the same code snippet twice. Removing this redundancy improves documentation clarity and prevents confusion for users.
Medium
Fix Python code indentation
The indentation in this Python code example is inconsistent and could confuse readers. The comments have extra indentation that doesn't match Python syntax standards, which could lead to copy-paste errors for users.
{{< tab header="Python" >}}
- # switching to second iframe based on index+# switching to second iframe based on index
iframe = driver.find_elements(By.TAG_NAME,'iframe')[1]
- # switch to selected iframe+# switch to selected iframe
driver.switch_to.frame(iframe)
{{< /tab >}}
Apply this suggestion
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies inconsistent indentation in the Python code example that doesn't follow Python syntax standards. Fixing this improves readability and prevents potential copy-paste errors for users implementing the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Fixed Frame Code- Demo -Purpose
Motivation and Context
Fixed Frame Code- Demo -Purpose
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Added live demo preparation comment in Python test file.
Improved formatting and added Python code snippets in Japanese documentation.
Enhanced Portuguese documentation with Python iframe switching example.
Adjusted tab formatting for better readability in documentation.
Changes walkthrough 📝
test_frames.py
Added live demo preparation comment in test fileexamples/python/tests/interactions/test_frames.py
frames.ja.md
Improved Japanese documentation with Python exampleswebsite_and_docs/content/documentation/webdriver/interactions/frames.ja.md
frames.pt-br.md
Enhanced Portuguese documentation with Python iframe examplewebsite_and_docs/content/documentation/webdriver/interactions/frames.pt-br.md