fix: use pSPI->begin() and add skipSpiBegin option for ESP32#159
Merged
Conversation
…ility ESP32 users need to call SPI.begin() with custom pin assignments before using the library (GPIO matrix). The hardcoded SPI.begin() in mcp2518fd::begin() overwrites this configuration. Changes: - Replace SPI.begin() with pSPI->begin() (consistent with MCP2515) - Add optional _initSPI parameter (default true) to begin() across MCP_CAN, mcp2515, and mcp2518fd so ESP32 users can skip SPI init Existing code is unaffected — default behavior unchanged. Closes #158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPI.begin()withpSPI->begin()in mcp2518fd (consistent with MCP2515)_initSPIparameter (defaulttrue) tobegin()across MCP_CAN, mcp2515, and mcp2518fdCAN.begin(CAN_500KBPS, MCP_8MHZ, false)to skip SPI re-initializationWhy
ESP32's GPIO matrix requires users to call
SPI.begin(SCK, MISO, MOSI, CS)with custom pins before using the library. The hardcodedSPI.begin()inmcp2518fd::begin()overwrites this configuration, breaking ESP32 support.Backward compatibility
_initSPI = true— existing code works unchangedpSPIalready points to&SPI)Closes #158