Refactor file cache handling and improve S3 rename functionality#847
Draft
jfantinhardesty wants to merge 4 commits intomainfrom
Draft
Refactor file cache handling and improve S3 rename functionality#847jfantinhardesty wants to merge 4 commits intomainfrom
jfantinhardesty wants to merge 4 commits intomainfrom
Conversation
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker,
brayan-trejo and
foodprocessor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Refactored cache space checks into a new
checkCacheSpacemethod infile_cache.go, replacing repetitive code. Removed fallback reopening logic for invalid handles in Truncate. Added a config flag for S3 that defaults to true to skip directory probing for paths ending in file-like extensions, improving performance on miss-heavy paths and refactored function to check for all file-like extensions rather than a few set extensions. Added a check in S3 Storage Rename File to prevent renaming a file to a directory.Checklist
Related Issues